Skip to content

Adding cache for recording_encryption resource #55857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: eriktate/sync-recording-encryption
Choose a base branch
from

Conversation

eriktate
Copy link
Contributor

@eriktate eriktate commented Jun 18, 2025

This adds cache support for the recording encryption resource. The only operation that makes use of the cache is decryption during replay which is powered by FindDecryptionKey

@eriktate eriktate force-pushed the eriktate/encrypted-recording-cache-and-events branch from c477750 to 9e0b61c Compare June 18, 2025 00:45
@eriktate eriktate force-pushed the eriktate/sync-recording-encryption branch from 5f70d06 to 603dbde Compare June 18, 2025 01:33
@eriktate eriktate force-pushed the eriktate/encrypted-recording-cache-and-events branch from 9e0b61c to 7032a39 Compare June 18, 2025 01:34
@eriktate eriktate force-pushed the eriktate/sync-recording-encryption branch 3 times, most recently from 3a22931 to f704ea7 Compare June 24, 2025 12:57
@eriktate eriktate force-pushed the eriktate/encrypted-recording-cache-and-events branch from 7032a39 to 8fe244f Compare June 24, 2025 13:49
@eriktate eriktate force-pushed the eriktate/sync-recording-encryption branch from f704ea7 to a89de49 Compare June 24, 2025 14:09
@eriktate eriktate force-pushed the eriktate/encrypted-recording-cache-and-events branch from 8fe244f to b6c22fe Compare June 24, 2025 14:10
@eriktate eriktate force-pushed the eriktate/sync-recording-encryption branch 2 times, most recently from 25e862e to d40fb37 Compare June 24, 2025 14:43
@eriktate eriktate force-pushed the eriktate/encrypted-recording-cache-and-events branch from b6c22fe to 7323861 Compare June 24, 2025 15:27
@eriktate eriktate force-pushed the eriktate/sync-recording-encryption branch 2 times, most recently from 41804ad to e9ec376 Compare June 24, 2025 19:33
@eriktate eriktate force-pushed the eriktate/encrypted-recording-cache-and-events branch 3 times, most recently from d4f3ac3 to 145dc0c Compare June 24, 2025 20:18
@eriktate eriktate force-pushed the eriktate/sync-recording-encryption branch from e9ec376 to 5d49ccd Compare June 24, 2025 20:24
@eriktate eriktate force-pushed the eriktate/encrypted-recording-cache-and-events branch from 145dc0c to 4fc9628 Compare June 24, 2025 20:26
@eriktate eriktate marked this pull request as ready for review June 24, 2025 20:34
@github-actions github-actions bot requested review from espadolini and rudream June 24, 2025 20:34
@eriktate eriktate force-pushed the eriktate/sync-recording-encryption branch from fddaaf7 to f6fc84e Compare June 24, 2025 22:44
@eriktate eriktate force-pushed the eriktate/encrypted-recording-cache-and-events branch from 4fc9628 to 5fb9b05 Compare June 24, 2025 22:49
@eriktate eriktate force-pushed the eriktate/sync-recording-encryption branch from f6fc84e to f5e7591 Compare June 24, 2025 23:17
@eriktate eriktate force-pushed the eriktate/encrypted-recording-cache-and-events branch from 5fb9b05 to 243c554 Compare June 24, 2025 23:36
Copy link
Contributor

@espadolini espadolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this missing the parser to convert backend events into typed watch events?

@eriktate eriktate force-pushed the eriktate/encrypted-recording-cache-and-events branch from 6928e8d to 9d9d44b Compare June 25, 2025 13:29
@eriktate eriktate force-pushed the eriktate/encrypted-recording-cache-and-events branch from 9d9d44b to 9bc2d2c Compare June 25, 2025 13:30
@eriktate
Copy link
Contributor Author

Isn't this missing the parser to convert backend events into typed watch events?

It was actually included in an earlier PR: https://github.com/gravitational/teleport/blob/master/lib/services/local/recording_encryption.go#L95-L128

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from rudream June 25, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants