fixing lint issues and amending comments

Author: eriktate

lib/auth/recordingencryption/manager.go

@@ -46,7 +46,7 @@ type KeyStore interface {
 	GetDecrypter(ctx context.Context, keyPair *types.EncryptionKeyPair) (crypto.Decrypter, error)
 }
 
-// A Cache fetches a cached *recordingencryptionv1.RecordingEncryption
+// A Cache fetches a cached [*recordingencryptionv1.RecordingEncryption]
 type Cache interface {
 	GetRecordingEncryption(context.Context) (*recordingencryptionv1.RecordingEncryption, error)
 }
@@ -61,26 +61,23 @@ type ManagerConfig struct {
 	LockConfig    backend.RunWhileLockedConfig
 }
 
-// NewManager returns a new Manager using the given ManagerConfig.
+// NewManager returns a new Manager using the given [ManagerConfig].
 func NewManager(cfg ManagerConfig) (*Manager, error) {
-
 	switch {
 	case cfg.Backend == nil:
 		return nil, trace.BadParameter("backend is required")
 	case cfg.ClusterConfig == nil:
 		return nil, trace.BadParameter("cluster config is required")
 	case cfg.KeyStore == nil:
 		return nil, trace.BadParameter("key store is required")
+	case cfg.Cache == nil:
+		return nil, trace.BadParameter("cache is required")
 	}
 
 	if cfg.Logger == nil {
 		cfg.Logger = slog.With(teleport.ComponentKey, "recording-encryption-manager")
 	}
 
-	if cfg.Cache == nil {
-		cfg.Cache = cfg.Backend
-	}
-
 	return &Manager{
 		RecordingEncryption:          cfg.Backend,
 		ClusterConfigurationInternal: cfg.ClusterConfig,
@@ -177,7 +174,7 @@ func (m *Manager) UpsertSessionRecordingConfig(ctx context.Context, cfg types.Se
 	return sessionRecordingConfig, trace.Wrap(err)
 }
 
-// SetCache overwrites the configured Cache implementation
+// SetCache overwrites the configured Cache implementation. It should only be called if the `Manager` is not in use.
 func (m *Manager) SetCache(cache Cache) {
 	m.cache = cache
 }

lib/cache/recording_encryption.go

@@ -14,7 +14,6 @@
 // You should have received a copy of the GNU Affero General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-//nolint:unused // Because the executors generate a large amount of false positives.
 package cache
 
 import (
@@ -65,10 +64,6 @@ func newRecordingEncryptionCollection(upstream services.RecordingEncryption, w t
 	}, nil
 }
 
-type recordingEncryptionCacheKey struct {
-	kind string
-}
-
 // GetRecordingEncryption returns the cached RecordingEncryption for the cluster
 func (c *Cache) GetRecordingEncryption(ctx context.Context) (*recordingencryptionv1.RecordingEncryption, error) {
 	ctx, span := c.Tracer.Start(ctx, "cache/GetRecordingEncryption")