[2] GraphiQL x Vite v5 #3679
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <link rel="icon" type="image/svg+xml" href="/test/images/logo.svg" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>GraphiQL</title> | ||
| <style> | ||
| body { | ||
| margin: 0; | ||
| } | ||
|
|
||
| #graphiql { | ||
| height: 100dvh; | ||
| } | ||
|
|
||
| .loading { | ||
| height: 100%; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| font-size: 4rem; | ||
| } | ||
| </style> | ||
| </head> | ||
| <body> | ||
| <div id="graphiql"> | ||
| <div class="loading">Loading…</div> | ||
| </div> | ||
| <script type="module"> | ||
| import React from 'react'; | ||
| import ReactDOM from 'react-dom/client'; | ||
| import GraphiQL from './src/cdn'; | ||
|
|
||
| Object.assign(globalThis, { | ||
| React, | ||
| ReactDOM, | ||
| GraphiQL, | ||
| }); | ||
| </script> | ||
| <script type="module" src="resources/renderExample.js"></script> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| module.exports = { | ||
| plugins: { | ||
| // https://github.com/postcss/postcss-import/issues/442#issuecomment-822427606 | ||
| 'postcss-import': '', | ||
| 'postcss-lightningcss': { | ||
| browsers: '>= .25%', | ||
| }, | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <link rel="icon" type="image/svg+xml" href="/test/images/logo.svg" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>GraphiQL</title> | ||
| <style> | ||
| body { | ||
| margin: 0; | ||
| } | ||
|
|
||
| #graphiql { | ||
| height: 100dvh; | ||
| } | ||
|
|
||
| .loading { | ||
| height: 100%; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| font-size: 4rem; | ||
| } | ||
| </style> | ||
| <script | ||
| crossorigin | ||
| src="https://unpkg.com/react@18/umd/react.development.js" | ||
| ></script> | ||
| <script | ||
| crossorigin | ||
| src="https://unpkg.com/react-dom@18/umd/react-dom.development.js" | ||
| ></script> | ||
| <link href="/dist/style.css" rel="stylesheet" /> | ||
| <script src="/dist/index.umd.js"></script> | ||
| </head> | ||
| <body> | ||
| <div id="graphiql"> | ||
| <div class="loading">Loading…</div> | ||
| </div> | ||
| <script type="module" src="/resources/renderExample.js"></script> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| import { defineConfig } from 'vite'; | ||
| import packageJSON from './package.json'; | ||
| import dts from 'vite-plugin-dts'; | ||
| import commonjs from 'vite-plugin-commonjs'; | ||
|
|
||
| const umdConfig = defineConfig({ | ||
| define: { | ||
| 'process.env.NODE_ENV': `"${process.env.NODE_ENV}"`, | ||
| }, | ||
| // To bundle `const { createClient } = require('graphql-ws')` in `createWebsocketsFetcherFromUrl` function | ||
| plugins: [commonjs()], | ||
| build: { | ||
| minify: true, | ||
dimaMachina marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| sourcemap: true, | ||
| emptyOutDir: false, | ||
| lib: { | ||
| entry: 'src/cdn.ts', | ||
| // 👇 The name of the exposed global variable. Required when the formats option includes umd or iife | ||
| name: 'GraphiQL', | ||
| fileName: 'index', | ||
| formats: ['umd'], | ||
| }, | ||
| rollupOptions: { | ||
| external: ['react', 'react-dom'], | ||
| output: { | ||
| globals: { | ||
| react: 'React', | ||
| 'react-dom': 'ReactDOM', | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| const esmConfig = defineConfig({ | ||
| build: { | ||
| minify: false, | ||
| sourcemap: true, | ||
| lib: { | ||
| entry: 'src/index.ts', | ||
| fileName: 'index', | ||
| formats: ['cjs', 'es'], | ||
|
There was a problem hiding this comment. do we really need a bundle of There was a problem hiding this comment. It's quite a big step to get rid of cjs, if it doesn't cost you much to keep outputting cjs? There was a problem hiding this comment. with dropping |
||
| }, | ||
| rollupOptions: { | ||
| external: [ | ||
| // Exclude peer dependencies and dependencies from bundle | ||
| ...Object.keys(packageJSON.peerDependencies), | ||
| ...Object.keys(packageJSON.dependencies), | ||
| ], | ||
| }, | ||
| }, | ||
| server: { | ||
| // prevent browser window from opening automatically | ||
| open: false, | ||
| proxy: { | ||
| '/graphql': 'http://localhost:8080', | ||
| '/bad/graphql': 'http://localhost:8080', | ||
| '/http-error/graphql': 'http://localhost:8080', | ||
| '/graphql-error/graphql': 'http://localhost:8080', | ||
| '/subscriptions': { | ||
| target: 'ws://localhost:8081', | ||
| ws: true, | ||
| }, | ||
| }, | ||
| }, | ||
| plugins: [dts({ rollupTypes: true })], | ||
| }); | ||
|
|
||
| export default process.env.UMD === 'true' ? umdConfig : esmConfig; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -114,6 +114,7 @@ linenumber | |
| linenumbers | ||
| linkify | ||
| listbox | ||
| lightningcss | ||
| listvalues | ||
| lostplan | ||
| maint | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found how to easily get version of
graphql-jswithout importingpackage.jsonor injecting code