[2] GraphiQL x Vite v5 #3679
Merged
[2] GraphiQL x Vite v5 #3679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ted Thibodeau Jr <[email protected]>
🦋 Changeset detectedLatest commit: 80bd1fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest changes of this PR are not available as canary, since there are no linked |
An error occurred while trying to automatically change base from
upd-cypress
to
main
August 7, 2024 00:29
dimaMachina
commented
Aug 7, 2024
| @@ -83,6 +83,7 @@ function getSchemaUrl() { | |||
| // how you can customize GraphiQL by providing different values or | |||
| // additional child elements. | |||
| const root = ReactDOM.createRoot(document.getElementById('graphiql')); | |||
| const graphqlVersion = GraphiQL.GraphQL.version; | |||
There was a problem hiding this comment.
found how to easily get version of graphql-js without importing package.json or injecting code
dimaMachina
commented
Aug 7, 2024
dimaMachina
commented
Aug 7, 2024
| lib: { | ||
| entry: 'src/index.ts', | ||
| fileName: 'index', | ||
| formats: ['cjs', 'es'], |
There was a problem hiding this comment.
do we really need a bundle of cjs version for the next major? or just keep esm?
There was a problem hiding this comment.
It's quite a big step to get rid of cjs, if it doesn't cost you much to keep outputting cjs?
There was a problem hiding this comment.
with dropping cjs we can bundle graphql-toolkit to esm only too and fix #3668
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## graphiql-v4 #3679 +/- ##
============================================
Coverage 60.85% 60.85%
============================================
Files 121 121
Lines 5620 5620
Branches 1490 1490
============================================
Hits 3420 3420
Misses 1748 1748
Partials 452 452
|
This was referenced Aug 7, 2024
Closed
dimaMachina
added a commit
that referenced
this pull request
May 2, 2025
* changeset pre enter alpha * [graphiql-react/graphiql] new looks of tabs (#3644) * new looks of tabs * add graphiql react too * all fixes * more polishing * more * more * more * more * more * prettier * polish changeset * disable shrinking while changing the operation name * Update packages/graphiql-react/src/ui/tabs.css Co-authored-by: Ted Thibodeau Jr <[email protected]> * yarn i * apply new design changes * prettier * Update .changeset/thirty-spoons-call.md * fix cypress * this fix locally --------- Co-authored-by: Ted Thibodeau Jr <[email protected]> * [2] GraphiQL x Vite v5 (#3679) * new looks of tabs * add graphiql react too * all fixes * more polishing * more * more * more * more * more * prettier * polish changeset * disable shrinking while changing the operation name * Update packages/graphiql-react/src/ui/tabs.css Co-authored-by: Ted Thibodeau Jr <[email protected]> * yarn i * apply new design changes * prettier * vite more more more * fix demo * fix cspell * fix dev * update cypress to v13 * upd cache key * Update .changeset/thirty-spoons-call.md * Update packages/graphiql/vite.config.mts * merge * add changeset * yarn.lock --------- Co-authored-by: Ted Thibodeau Jr <[email protected]> * [3] remove unused webpack deps (#3681) * new looks of tabs * add graphiql react too * all fixes * more polishing * more * more * more * more * more * prettier * polish changeset * disable shrinking while changing the operation name * Update packages/graphiql-react/src/ui/tabs.css Co-authored-by: Ted Thibodeau Jr <[email protected]> * yarn i * apply new design changes * prettier * vite more more more * fix demo * fix cspell * fix dev * update cypress to v13 * upd cache key * remove webpack deps * fix `yarn jest --coverage` * Update .changeset/thirty-spoons-call.md * Update packages/graphiql/vite.config.mts * merge * add changeset * yarn.lock * yarn.lock --------- Co-authored-by: Ted Thibodeau Jr <[email protected]> * [4] update graphql to `16.9.0` and use vite `define` configuration to remove development code from cdn bundle (#3683) * vite more more more * fix demo * fix cspell * fix dev * update cypress to v13 * upd cache key * remove webpack deps * fix `yarn jest --coverage` * upd graphql * aa * yarn.lock * fix tests * remove `data-testid="graphiql-container"` (#3688) * commit `pre.json` until `graphiql-v4` will be added to list of authorized branches to deploy * remove `graphiql-v4` from release.yml * [v4] remove `disableTabs` option (#3687) * remove `disableTabs` option * format * commit `pre.json` * add `graphiql-v4` in release.yml * [v4] prefer `location` over `window.location` and prefer `navigator` over `window.navigator` (#3692) * [v4] remove `build.sh` and `checkgit.sh` (#3694) * [v4] test umd build only on ci, locally test cdn.ts (#3693) * test umd build only on ci, locally test cdn.ts * Update custom-words.txt * [v4] convert graphiql e2e server to ESM (#3697) * aa * fix netlify * fix * fix fails on ci * [v4] update changeset for changed exports (#3700) * [v4] generate types with `vite-plugin-dts` (#3702) * generate types with `vite-plugin-dts` * add types:check in prebuild * more * more * more * update vite * upd * use terser * [v4] use `vite build --watch` instead of `vite` for `dev` script because we don't need development server for them (#3705) * [v4] remove graphiql default export (#3706) * aa * aa * polish * [v4] fix netlify deploy (#3708) * fix netlify deploy * fix cypress * change `style.css` imports (#3709) * Update poor-ghosts-jump.md * Version Packages (alpha) (#3689) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [v4] show tabs even there is only 1 tab (#3713) * aa * aa * fix unit tests * fix cypress * [v4] Remove `toolbar.additionalContent` and `toolbar.additionalComponent` props in favor of `GraphiQL.Toolbar` render props. (#3707) * Version Packages (alpha) (#3714) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [v4] use `position: absolute` for `.graphiql-logo` class (#3716) * [v4] remove `createComponentGroup` utility in favour `Object.assign` (#3717) * Version Packages (alpha) (#3718) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [v4] fix merge conflicts with `main` (#3719) * upgrade to graphql v17 including support for new incremental delivery format (#3682) * add support for new incremental delivery format * fix vitest * add patch for graphql-js bug submittes upstream with test at graphql/graphql-js#4160 * apply feedback * move patches! * some fixes * fix netlify/cypress * remove export * update changeset --------- Co-authored-by: Dimitri POSTOLOV <[email protected]> * Version Packages (#3715) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * prettier * fix e2e * update pr-graphql-compat-check.yml * prettier --------- Co-authored-by: Yaacov Rydzinski <[email protected]> Co-authored-by: Rikki Schulte <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [v4] fix scrollbar appearing in sidebar (#3720) * replace `overflow-y: scroll` with `overflow-y: auto` * fix netlify graphql function * Version Packages (alpha) (#3723) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * style: Don't convert single \n to <br> (#3414) * Update development instructions * Don't convert single \n to <br> * Add changeset * Update .changeset/olive-mice-hide.md --------- Co-authored-by: Dimitri POSTOLOV <[email protected]> * [v4] some refactoring (#3726) * some refactoring * use `right: var(--px-16)` instead of `right: 0` for `.graphiql-logo` * more * try to fix * fix join is not defined * Update packages/graphiql/cypress/e2e/incremental-delivery.cy.ts Co-authored-by: Ted Thibodeau Jr <[email protected]> --------- Co-authored-by: Ted Thibodeau Jr <[email protected]> * [v4] polish `tabs.cy` tests, remove `.graphiql-session` class (#3728) * aa * aa * aa * aa * fix tests * [v4] rollback `position: absolute` style for `.graphiql-logo` because tabs will behind logo (#3730) * Version Packages (alpha) (#3725) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add support for onPrettifyQuery callback to enable customised query formatting (#3733) * aa * prettifyyy * Version Packages (alpha) (#3732) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [v4] improve explorer styles (#3738) * improve explorer styles * aa * Version Packages (alpha) (#3739) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix types incorrect types entry (#3740) * Version Packages (alpha) (#3741) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * add vite replace html plugin for graphiql plugin explorer (#3742) * add vite replace html plugin for graphiql plugin explorer * fix build * temp * migrate `@graphiql/toolkit` to `tsup` (#3746) * aa * removes unneeded `undefined` * try * fix * fix vitest * rollback of `temp` commit * update lock * merge * Update .changeset/rich-jobs-kick.md * polish * lint * Update .changeset/good-vans-refuse.md * update migration guide * update migration guide * upd * upd * fix * make on prettify query async * use maybe promise from toolkit * upd * message processor test pass * fix e2e * try * FIX e2e * try * ok now it's good * I hope now it's ok! --------- Co-authored-by: Ted Thibodeau Jr <[email protected]> Co-authored-by: Rikki Schulte <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Yaacov Rydzinski <[email protected]> Co-authored-by: Leonard Ehrenfried <[email protected]>
dimaMachina
added a commit
that referenced
this pull request
May 3, 2025
* add some changes to create new branch * [v3] update vite to v6 (#3828) * upd * rm postcss since it's included in vite * prettier * upd * upd * upd * fix lint * [graphiql]: support react 19, drop support react 16 and react 17 (#3897) * upd * upd * upd * upd * upd * exclude react-dom/client from bundle * bump react everywhere to v19 * bump react everywhere to v19 * polish * fix failing text, to unblock canary * upd * try `minor` for graphiql/react, otherwise it pines to `1.0.0-next.2` in esm.sh * try workaround * try workaround * try workaround * try workaround * this should fix vitest * try * try * lint * try * fix test * try SOURCEMAP var * try ESM_SH_BUILD var * try * rm some unneeded code * try to fix esbuild: package 'uWebSockets.js' not found * update vite to see if it fix esbuild error? * bump module "@emotion/is-prop-valid" not found to fix `module "@emotion/is-prop-valid" not found` on esm.sh * upd * upd * upd * fix e2e * add changeset * add migration markdown file * fix * Update GraphiQL CDN example using ESM-based CDN esm.sh (#3902) * upd * upd * upd * upd * upd * exclude react-dom/client from bundle * bump react everywhere to v19 * bump react everywhere to v19 * polish * fix failing text, to unblock canary * upd * try `minor` for graphiql/react, otherwise it pines to `1.0.0-next.2` in esm.sh * try workaround * try workaround * try workaround * try workaround * this should fix vitest * try * try * lint * try * fix test * try SOURCEMAP var * try ESM_SH_BUILD var * try * rm some unneeded code * try to fix esbuild: package 'uWebSockets.js' not found * update vite to see if it fix esbuild error? * bump module "@emotion/is-prop-valid" not found to fix `module "@emotion/is-prop-valid" not found` on esm.sh * upd * upd * upd * fix e2e * add changeset * add migration markdown file * fix * upd * upd graphiql plugin explorer docs * upd * upd * upd * update code exporter * upd * upd * upd * upd * upd * upd * polish * add changeset * new tabs look for graphiql v4 (#3685) * changeset pre enter alpha * [graphiql-react/graphiql] new looks of tabs (#3644) * new looks of tabs * add graphiql react too * all fixes * more polishing * more * more * more * more * more * prettier * polish changeset * disable shrinking while changing the operation name * Update packages/graphiql-react/src/ui/tabs.css Co-authored-by: Ted Thibodeau Jr <[email protected]> * yarn i * apply new design changes * prettier * Update .changeset/thirty-spoons-call.md * fix cypress * this fix locally --------- Co-authored-by: Ted Thibodeau Jr <[email protected]> * [2] GraphiQL x Vite v5 (#3679) * new looks of tabs * add graphiql react too * all fixes * more polishing * more * more * more * more * more * prettier * polish changeset * disable shrinking while changing the operation name * Update packages/graphiql-react/src/ui/tabs.css Co-authored-by: Ted Thibodeau Jr <[email protected]> * yarn i * apply new design changes * prettier * vite more more more * fix demo * fix cspell * fix dev * update cypress to v13 * upd cache key * Update .changeset/thirty-spoons-call.md * Update packages/graphiql/vite.config.mts * merge * add changeset * yarn.lock --------- Co-authored-by: Ted Thibodeau Jr <[email protected]> * [3] remove unused webpack deps (#3681) * new looks of tabs * add graphiql react too * all fixes * more polishing * more * more * more * more * more * prettier * polish changeset * disable shrinking while changing the operation name * Update packages/graphiql-react/src/ui/tabs.css Co-authored-by: Ted Thibodeau Jr <[email protected]> * yarn i * apply new design changes * prettier * vite more more more * fix demo * fix cspell * fix dev * update cypress to v13 * upd cache key * remove webpack deps * fix `yarn jest --coverage` * Update .changeset/thirty-spoons-call.md * Update packages/graphiql/vite.config.mts * merge * add changeset * yarn.lock * yarn.lock --------- Co-authored-by: Ted Thibodeau Jr <[email protected]> * [4] update graphql to `16.9.0` and use vite `define` configuration to remove development code from cdn bundle (#3683) * vite more more more * fix demo * fix cspell * fix dev * update cypress to v13 * upd cache key * remove webpack deps * fix `yarn jest --coverage` * upd graphql * aa * yarn.lock * fix tests * remove `data-testid="graphiql-container"` (#3688) * commit `pre.json` until `graphiql-v4` will be added to list of authorized branches to deploy * remove `graphiql-v4` from release.yml * [v4] remove `disableTabs` option (#3687) * remove `disableTabs` option * format * commit `pre.json` * add `graphiql-v4` in release.yml * [v4] prefer `location` over `window.location` and prefer `navigator` over `window.navigator` (#3692) * [v4] remove `build.sh` and `checkgit.sh` (#3694) * [v4] test umd build only on ci, locally test cdn.ts (#3693) * test umd build only on ci, locally test cdn.ts * Update custom-words.txt * [v4] convert graphiql e2e server to ESM (#3697) * aa * fix netlify * fix * fix fails on ci * [v4] update changeset for changed exports (#3700) * [v4] generate types with `vite-plugin-dts` (#3702) * generate types with `vite-plugin-dts` * add types:check in prebuild * more * more * more * update vite * upd * use terser * [v4] use `vite build --watch` instead of `vite` for `dev` script because we don't need development server for them (#3705) * [v4] remove graphiql default export (#3706) * aa * aa * polish * [v4] fix netlify deploy (#3708) * fix netlify deploy * fix cypress * change `style.css` imports (#3709) * Update poor-ghosts-jump.md * Version Packages (alpha) (#3689) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [v4] show tabs even there is only 1 tab (#3713) * aa * aa * fix unit tests * fix cypress * [v4] Remove `toolbar.additionalContent` and `toolbar.additionalComponent` props in favor of `GraphiQL.Toolbar` render props. (#3707) * Version Packages (alpha) (#3714) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [v4] use `position: absolute` for `.graphiql-logo` class (#3716) * [v4] remove `createComponentGroup` utility in favour `Object.assign` (#3717) * Version Packages (alpha) (#3718) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [v4] fix merge conflicts with `main` (#3719) * upgrade to graphql v17 including support for new incremental delivery format (#3682) * add support for new incremental delivery format * fix vitest * add patch for graphql-js bug submittes upstream with test at graphql/graphql-js#4160 * apply feedback * move patches! * some fixes * fix netlify/cypress * remove export * update changeset --------- Co-authored-by: Dimitri POSTOLOV <[email protected]> * Version Packages (#3715) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * prettier * fix e2e * update pr-graphql-compat-check.yml * prettier --------- Co-authored-by: Yaacov Rydzinski <[email protected]> Co-authored-by: Rikki Schulte <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [v4] fix scrollbar appearing in sidebar (#3720) * replace `overflow-y: scroll` with `overflow-y: auto` * fix netlify graphql function * Version Packages (alpha) (#3723) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * style: Don't convert single \n to <br> (#3414) * Update development instructions * Don't convert single \n to <br> * Add changeset * Update .changeset/olive-mice-hide.md --------- Co-authored-by: Dimitri POSTOLOV <[email protected]> * [v4] some refactoring (#3726) * some refactoring * use `right: var(--px-16)` instead of `right: 0` for `.graphiql-logo` * more * try to fix * fix join is not defined * Update packages/graphiql/cypress/e2e/incremental-delivery.cy.ts Co-authored-by: Ted Thibodeau Jr <[email protected]> --------- Co-authored-by: Ted Thibodeau Jr <[email protected]> * [v4] polish `tabs.cy` tests, remove `.graphiql-session` class (#3728) * aa * aa * aa * aa * fix tests * [v4] rollback `position: absolute` style for `.graphiql-logo` because tabs will behind logo (#3730) * Version Packages (alpha) (#3725) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add support for onPrettifyQuery callback to enable customised query formatting (#3733) * aa * prettifyyy * Version Packages (alpha) (#3732) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [v4] improve explorer styles (#3738) * improve explorer styles * aa * Version Packages (alpha) (#3739) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix types incorrect types entry (#3740) * Version Packages (alpha) (#3741) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * add vite replace html plugin for graphiql plugin explorer (#3742) * add vite replace html plugin for graphiql plugin explorer * fix build * temp * migrate `@graphiql/toolkit` to `tsup` (#3746) * aa * removes unneeded `undefined` * try * fix * fix vitest * rollback of `temp` commit * update lock * merge * Update .changeset/rich-jobs-kick.md * polish * lint * Update .changeset/good-vans-refuse.md * update migration guide * update migration guide * upd * upd * fix * make on prettify query async * use maybe promise from toolkit * upd * message processor test pass * fix e2e * try * FIX e2e * try * ok now it's good * I hope now it's ok! --------- Co-authored-by: Ted Thibodeau Jr <[email protected]> Co-authored-by: Rikki Schulte <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Yaacov Rydzinski <[email protected]> Co-authored-by: Leonard Ehrenfried <[email protected]> * GraphiQL v4: exit changeset alpha (#3907) * exit changeset * polish migration guide * bump version * bump version * upd * Update graphiql-4.0.0.md --------- Co-authored-by: Ted Thibodeau Jr <[email protected]> Co-authored-by: Rikki Schulte <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Yaacov Rydzinski <[email protected]> Co-authored-by: Leonard Ehrenfried <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2925 #2371 #2638 #2184
I propose to cut v4 alpha release and include this PR and new tabs looks PR #3644
changed exports
graphiql/graphiql.jsremoved non-minified umd bundlegraphiql/graphiql.min.js=>graphiql/dist/index.umd.jsgraphiql/graphiql.css=>graphiql/style.css(addedexportsfield inpackage.json)todos:
import 'graphiql/style.css';[v4] update changeset for changed exports #3700