-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a fallback to inline environment when path doesn't exist #637
Add a fallback to inline environment when path doesn't exist #637
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Bump to drop stale. |
👍 I have no objection for this feature. I'd like to see some testing around it though. There's already a few tests in |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Bump to drop stale. I will look at adding some tests. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Bump to drop stale, haven't had chance to add tests to this yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added tests and a better error message in case multiple envs are found. Since I added code, I'll ask for another approval from my team
1857063
to
284dc43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Thanks for your contribution @josephglanville! |
This is a feature proposal PoC for #636
It allows a user to reference an inline environment by name if it's present in the current working directory.
i.e instead of:
Can simply write:
Because this patch replaces the path with the current working directory the standard enumeration logic will be used to discover the environment.