Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature-request: Interpret env name as inline if directory can't be found #636

Closed
josephglanville opened this issue Oct 26, 2021 · 7 comments

Comments

@josephglanville
Copy link
Contributor

josephglanville commented Oct 26, 2021

My Tanka workflow has led to extensive use of inline environments for various reasons.

One quality of life improvement would be not to need to type tk --name <env_name> main.jsonnet but rather tk <env_name> again like can be done with non-inline/traditional environment setup with spec.json.

I did a quick PoC of this by detecting when the path doesn't exist, falling back to the current directory as the basedir and setting name to be the non-existent path.

This works but probably needs more thought put into UX and edge cases, patch is tiny and works in the cases I wanted it to: https://github.com/josephglanville/tanka/tree/jpg/fallback-inline

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 9, 2022
@josephglanville
Copy link
Contributor Author

Bump to drop stale.

@stale stale bot removed the stale label Jan 17, 2022
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 2, 2022
@josephglanville
Copy link
Contributor Author

Bump to drop stale

@stale stale bot removed the stale label Mar 2, 2022
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@josephglanville
Copy link
Contributor Author

Bump to drop stale

@stale stale bot removed the stale label Apr 17, 2022
@julienduchesne
Copy link
Member

#637 merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants