Skip to content

detect all types of null default value #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2022
Merged

detect all types of null default value #1685

merged 3 commits into from
Jul 1, 2022

Conversation

pngwn
Copy link
Member

@pngwn pngwn commented Jul 1, 2022

ALternative to #1645.

  • This PR checks for all types of 'null' default value (i.e. the value we get when no default value is provided), fixing the interactive/ non-interactive autodetection when no default value is given.
  • I had to modify the preprocessing for Radio (which Dropdown inherits) as it was selecting the first value for the user even when none was given. I can kind of understand the reasoning but if we do this we have no way of knowing whether or a not a default value is being passed or not. I don't think we should be selecting a value for the user if they have not provided a valid one.

Closes #1569.

@pngwn pngwn requested a review from aliabid94 July 1, 2022 14:10
@pngwn pngwn mentioned this pull request Jul 1, 2022
@aliabid94
Copy link
Collaborator

makes sense to me

@pngwn pngwn merged commit a2b8419 into main Jul 1, 2022
@pngwn pngwn deleted the 1569-interactivity-alt branch July 1, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown is disabled when created with blocks
2 participants