fix interactivity #1645
Closed
fix interactivity #1645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm I see the point of reducing "magic", but I also think placing a static image as |
|
Yeah, I agree. Personally I like the autodetection logic. I'll make an alternative PR that tackles any bugs with the current implementation and we can decide which to keep. |
|
@aliabid94 Alternative retaining the magic is here: #1685 |
|
Closing in favour of #1685 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1569.
Previously there were some issues with interactivity auto-detection. It was actually working as intended for the most part but it was a little confusing. The important factor here was that components needed to have no default_value in order to appear as dynamic. As soon as you gave them a default_value, the logic determined that if they have no inputs or outputs they are static. This makes sense in general but is slightly confusing when developing the application before all events have been hooked up.
This PR is more of a proposal. It essentially means that components which act only as an output will rename static, everything else is dynamic regardless of whether there is a default value. It is less magical but much easier to understand. Most of the time the component will be dynamic, users will always have the
interactive=Falsekwarg for those times when they need to go against the very simple auto behaviour.