Disable overshootClamping for small bottom sheets to avoid Reanimated issue

[sharifhh]

Hi!

Reanimated v4 introduced a bug in withSpring
software-mansion/react-native-reanimated#7947
software-mansion/react-native-reanimated#7803

this is a temp solution to make this library work for small bottom sheets

[matiaswastaken]

With this fix it partially works, but the starting animation is gone meaning when you open the sheet you arent getting the smooth animation (basically same as animateOnMount=false)

[sharifhh]

actually my whole fix is not needed, the issue is in the new react-native-reanimated withSpring, try to play with the animation configuration and you will see that it works

[matiaswastaken]

@sharifhh oh hmm, can you share what steps i have to do get this working?

[sharifhh]

these are the default configs

const ANIMATION_EASING: Animated.EasingFunction = Easing.out(Easing.exp);
const ANIMATION_DURATION = 250;

const ANIMATION_CONFIGS_IOS = {
  damping: 500,
  stiffness: 1000,
  mass: 3,
  overshootClamping: true,
  restDisplacementThreshold: 10,
  restSpeedThreshold: 10,
};

const ANIMATION_CONFIGS_ANDROID = {
  duration: ANIMATION_DURATION,
  easing: ANIMATION_EASING,
};

const ANIMATION_CONFIGS =
  Platform.OS === 'ios' ? ANIMATION_CONFIGS_IOS : ANIMATION_CONFIGS_ANDROID;

now

  restDisplacementThreshold: 10,
restSpeedThreshold: 10,

are removed from withSpring so ignore them, and just set overshootClamping as false and it will be resolved.

I found the issue in reanimated and starting a thread there, will keep you posted and link it here

[sharifhh]

software-mansion/react-native-reanimated#7947

[matiaswastaken]

Thanks for the effort. Is there any quickfix patch that can be applied while we wait, I would need this to be fixed ASAP.

EDIT: Ah just set overshootClamping: false and it seems to work fine. Thanks.

[sharifhh]

software-mansion/react-native-reanimated#7948

[Willham12]

Perfect, thanks mate. fix #2272

[justynpollard1]

Thanks, setting overshootClamping: false in animation config fixed this for me as well. Before my sheets would blink quickly and not appear or just not appear at all.

[KatChaotic]

Thanks, I apply this changes locally with patch and now modals start working on iOS after migration to new versions

[Yurii-Lutsyk]

Thanks you!!!

[Splanis]

OMG thanks