[codegen] Typed data source for offsets in records #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take two. This adds a new getter for offset fields in records, where instead of passing in the `FontData` you pass in the appropriate table itself.
cmyr
force-pushed
the
typed-record-offset-data2
branch
from
7e6ee81 to
b730cb2
Compare
rsheeter
reviewed
Apr 28, 2025
| @@ -431,9 +431,23 @@ impl BaseScriptRecord { | |||
| /// | |||
| /// The `data` argument should be retrieved from the parent table | |||
| /// By calling its `offset_data` method. | |||
| /// | |||
| /// NOTE: you should prefer to use [`read_base_script`][Self::read_base_script], | |||
| /// which takes the relevant parent table as input, instead of raw `FontData`. | |||
| pub fn base_script<'a>(&self, data: FontData<'a>) -> Result<BaseScript<'a>, ReadError> { | |||
There was a problem hiding this comment.
I think these ones should be #[deprecated]
There was a problem hiding this comment.
last time I deprecated right away, dominik complained that it broke his build. I agree that this is a bit annoying though because without deprecating it's hard to point people to the new methods? cc @drott
rsheeter
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take two. This adds a new getter for offset fields in records, where instead of passing in the
FontDatayou pass in the appropriate table itself.