[codegen] Add OffsetSource trait #1472
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a way of encoding the source of offset data in the case where it has to be passed in. With this change, the method for getting a `Script` from a `ScriptRecord` looks like, ```rust fn script<'a>(&self, data: impl OffsetSource<'a, ScriptList<'a>>) ``` instead of, ```rust fn script<'a>(&self, data: FontData<'a>) ``` To avoid breakage, `FontData` can still be passed directly to any method that accepts an `OffsetSource` argument. This is not publically documented, though, and it is expected that new code would pass in the tables themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a way of encoding the source of offset data in the case where it has to be passed in, which has been a longstanding request.
With this change, the method for getting a
Scriptfrom aScriptRecordlooks like,instead of,
To avoid breakage (this should break no existing code),
FontDatacan still be passed directly to any method that accepts anOffsetSourceargument. This is not publicly documented, though, and it is expected that new code would pass in the tables themselves.