Skip to content

chore: include showcase module in test coverage report #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 24, 2023
Merged

chore: include showcase module in test coverage report #1548

merged 8 commits into from
Mar 24, 2023

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Mar 23, 2023 •
edited
Loading

Jacoco results for unit tests:
Screenshot 2023-03-23 at 4 29 36 PM

Jacoco results for integration tests:

Screenshot 2023-03-23 at 4 33 11 PM

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 23, 2023
@mpeddada1 mpeddada1 changed the title Include showcase coverage chore: include showcase module in test coverage report Mar 23, 2023
@mpeddada1 mpeddada1 requested a review from burkedavison March 23, 2023 20:59
@mpeddada1 mpeddada1 marked this pull request as ready for review March 23, 2023 20:59
@mpeddada1 mpeddada1 requested a review from a team as a code owner March 23, 2023 20:59
@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mpeddada1 mpeddada1 merged commit 498ddfa into main Mar 24, 2023
@mpeddada1 mpeddada1 deleted the include-showcase-coverage branch March 24, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burkedavison burkedavison burkedavison approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpeddada1 @burkedavison