Skip to content

Commit 498ddfa

Browse files
authored
chore: include showcase module in test coverage report (#1548)
* chore: add showcase classes to test coverage
1 parent 78f3f55 commit 498ddfa

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

coverage-report/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ In order to view aggregate unit test coverage of api-common and GAX in `api-comm
1010
1. At the root of the repository, run `mvn clean test -DenableTestCoverage`.
1111
2. The metrics can be found at `gapic-generator-java/coverage-report/target/site/jacoco-aggregate/index.html`
1212

13-
![Screenshot 2023-03-21 at 12 25 41 PM](https://user-images.githubusercontent.com/66699525/226675190-5225e778-99d4-44d0-8177-29d48d1c35ee.png)
13+
![Screenshot 2023-03-23 at 4 29 36 PM](https://user-images.githubusercontent.com/66699525/227346653-b50ec440-71f9-49f4-be21-3976c7f995c7.png)
1414

1515
### Integration Test Coverage
1616

@@ -19,4 +19,4 @@ In order to view aggregate integration test coverage of api-common and GAX in `a
1919
1. At the root of the repository, run `mvn clean verify -DskipUnitTests -DenableTestCoverage -Penable-integration-tests`.
2020
2. The metrics can be found at `gapic-generator-java/coverage-report/target/site/jacoco-aggregate/index.html`
2121

22-
![Screenshot 2023-03-21 at 12 26 26 PM](https://user-images.githubusercontent.com/66699525/226675461-97a1c4b5-a90f-470d-b0c8-51e63a35a548.png)
22+
![Screenshot 2023-03-23 at 4 33 11 PM](https://user-images.githubusercontent.com/66699525/227348487-f1ba2bb8-7577-4280-a1a1-7aa78e242f12.png)

coverage-report/pom.xml

-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
<groupId>com.google.cloud</groupId>
2828
<artifactId>gapic-showcase</artifactId>
2929
<version>0.0.1-SNAPSHOT</version>
30-
<scope>test</scope>
3130
</dependency>
3231
<dependency>
3332
<groupId>com.google.api</groupId>

showcase/pom.xml

+9-2
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
<checkstyle.skip>true</checkstyle.skip>
2828
<clirr.skip>true</clirr.skip>
2929
<enforcer.skip>true</enforcer.skip>
30-
<skipUnitTests>true</skipUnitTests>
3130
</properties>
3231

3332
<dependencyManagement>
@@ -74,8 +73,16 @@
7473
<plugin>
7574
<groupId>org.apache.maven.plugins</groupId>
7675
<artifactId>maven-surefire-plugin</artifactId>
76+
<version>3.0.0-M8</version>
7777
<configuration>
78-
<skip>${skipUnitTests}</skip>
78+
<!-- Exclude MessagingClientHttpJsonTest which is currently failing.
79+
See https://github.com/googleapis/gapic-generator-java/issues/1547 -->
80+
<!-- TODO(1547): Remove this exclusion once MessagingClientHttpJsonTest#updateBlurbTest is fixed -->
81+
<excludes>
82+
<exclude>**/MessagingClientHttpJsonTest.java</exclude>
83+
</excludes>
84+
<reportNameSuffix>sponge_log</reportNameSuffix>
85+
<skipTests>${skipUnitTests}</skipTests>
7986
</configuration>
8087
</plugin>
8188
<plugin>

0 commit comments

Comments
 (0)