-
Notifications
You must be signed in to change notification settings - Fork 30
Java: support multiple versions per release #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: support multiple versions per release #74
Conversation
@theacodes @busunkim96 As I'm not a pythonista yet, should I break the internal classes in here into separate files? |
What would the usage look like in gax-java? |
I haven't looked into the gradle release process yet. |
I don't think it needs to be built into the gradle release process yet; the question was more about how the direct commands would look. |
@garrettjonesgoogle I meant looking into how gradle handles release and snapshot versioning. The releasetool workflow should be identical. |
@chingor13 Ok. So what commands would I run manually to invoke the bump & replace-versions logic? |
If you want to separate the steps, you can do so by replying no to selective prompts. Both scenarios would start with If you want to just bump, you can say yes to updating If you want to just replace the versions, you can say no to updating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm cool with this
This is ready to go whenever. |
Java publishes packages together and different artifacts are versioned independently. We already have precedent in google-cloud-java to manage all versions in a
versions.txt
file at the root directory and to be able to annotate places to replace throughout theREADME.md
andpom.xml
files.This PR replaces the current
utilites/bump_versions.py
andutilities/replace_versions.py
scripts in google-cloud-java so they can be used with other repositories like gax-java.The workflow is now:
See googleapis/google-cloud-java#3777
This should make releasetool work for all of google-cloud-java, gax-java, google-auth-library-java, google-api-java-client, google-http-java-client, google-oauth-java-client.