Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Releasetool compatibility and instructions #598

Merged
merged 6 commits into from
Oct 11, 2018

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Oct 8, 2018

Depends on googleapis/releasetool#74

  • Move the individual version.txt versions into a single version.txt file at the root
  • Tag all locations in the repo that need versions to be updated at each release
  • Delete the templates/ directory
  • Delete the updateSamples and updateReadme tasks in build.gradle
  • Update the release instructions

Fixes #595

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2018
@codecov-io
Copy link

codecov-io commented Oct 8, 2018

Codecov Report

Merging #598 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #598   +/-   ##
=========================================
  Coverage     75.02%   75.02%           
  Complexity      934      934           
=========================================
  Files           176      176           
  Lines          4076     4076           
  Branches        323      323           
=========================================
  Hits           3058     3058           
  Misses          865      865           
  Partials        153      153

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b842b23...0432d60. Read the comment docs.

@garrettjonesgoogle
Copy link
Member

Fixes #595

A couple missing things from the issue:

  • Delete the templates/ directory
  • Delete the updateSamples and updateReadme tasks in build.gradle

@chingor13 chingor13 changed the title WIP: releasetool compatibility and instructions Releasetool compatibility and instructions Oct 10, 2018
@chingor13
Copy link
Contributor Author

We can't fully remove the templates/ directory as the createApiDocsRedirect gradle task cannot be replicated by releasetool

Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right! That makes sense.

@chingor13 chingor13 merged commit eca14d4 into googleapis:master Oct 11, 2018
Raibaz pushed a commit to Raibaz/gax-java that referenced this pull request Oct 25, 2018
* Use explicit versions in build.gradle and add replace tags

* Add benchmark artifact version

* Update RELEASING.md with releasetool usage

* Remove version.txt files. They are now managed by the versions.txt file

* Fix starting versions of benchmark and gax-httpjson artifacts

* README.md and samples/pom.xml can use releasetool's replacement feature
Raibaz pushed a commit to Raibaz/gax-java that referenced this pull request Oct 25, 2018
* Use explicit versions in build.gradle and add replace tags

* Add benchmark artifact version

* Update RELEASING.md with releasetool usage

* Remove version.txt files. They are now managed by the versions.txt file

* Fix starting versions of benchmark and gax-httpjson artifacts

* README.md and samples/pom.xml can use releasetool's replacement feature
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants