This repository was archived by the owner on Sep 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 106
Releasetool compatibility and instructions #598
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #598 +/- ##
=========================================
Coverage 75.02% 75.02%
Complexity 934 934
=========================================
Files 176 176
Lines 4076 4076
Branches 323 323
=========================================
Hits 3058 3058
Misses 865 865
Partials 153 153 Continue to review full report at Codecov.
|
Fixes #595 A couple missing things from the issue:
|
1f9ff54
to
0432d60
Compare
We can't fully remove the |
garrettjonesgoogle
approved these changes
Oct 11, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, right! That makes sense.
Raibaz
pushed a commit
to Raibaz/gax-java
that referenced
this pull request
Oct 25, 2018
* Use explicit versions in build.gradle and add replace tags * Add benchmark artifact version * Update RELEASING.md with releasetool usage * Remove version.txt files. They are now managed by the versions.txt file * Fix starting versions of benchmark and gax-httpjson artifacts * README.md and samples/pom.xml can use releasetool's replacement feature
Raibaz
pushed a commit
to Raibaz/gax-java
that referenced
this pull request
Oct 25, 2018
* Use explicit versions in build.gradle and add replace tags * Add benchmark artifact version * Update RELEASING.md with releasetool usage * Remove version.txt files. They are now managed by the versions.txt file * Fix starting versions of benchmark and gax-httpjson artifacts * README.md and samples/pom.xml can use releasetool's replacement feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on googleapis/releasetool#74
Fixes #595