PKCS decoder fuzz test #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
/cc @evildour |
This fails without PR googleapis#937, passes with it
chrisdunelm
force-pushed
the
pkcs
branch
2 times, most recently
from
11401ae to
67ea814
Compare
jskeet
approved these changes
Mar 23, 2017
| // This test does take a few (possibly 10s of) seconds, longer than most unit tests. | ||
| for (int i = 0; i < 1000; i++) | ||
| { | ||
| // This SecureRandom construtor is deprecated, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| try | ||
| { | ||
| // Throws CryptographicException if the rsaParameters is invalid | ||
| key.ImportParameters(rsaParameters); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
And make TrimLeadingZeroes() internal
evildour
reviewed
Mar 23, 2017
| // Check that all the parameters exported are equal to the originally created parameters | ||
| var exportedParams = key.ExportParameters(true); | ||
| var privateKey = (Org.BouncyCastle.Crypto.Parameters.RsaPrivateCrtKeyParameters)keys.Private; | ||
| Assert.That(Pkcs8.TrimLeadingZeroes(exportedParams.P, false), Is.EqualTo(privateKey.P.ToByteArrayUnsigned())); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fails without PR #937, passes with it