Fix PKCS8 decoding for some RSA private keys #937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
(ready to be reviewed) |
|
Assigned to Chris as I believe he wrote this code :) |
|
Hold off on reviewing. I just realized I introduced a bug in the array copying logic. |
|
Ok, fixed now. PTAL. |
|
Just to check, is this still needed bearing in mind your other changes around URL signing? |
|
I'm fairly sure this PR and URL signing are unrelated. I expect to get time to review this PR today. |
|
Yes, this is unrelated and just an odd edge case Ian happened to hit with the first credentials for the CI service account. |
chrisdunelm
added a commit
to chrisdunelm/google-api-dotnet-client
that referenced
this pull request
Mar 22, 2017
This fails without PR googleapis#937, passes with it
Merged
|
I have created PR #938, which generates many RSA keys in PKCS8 format and verifies the Pkcs8 class now decodes them successfully. This fails (as expected) without the fix in this PS. |
chrisdunelm
added a commit
to chrisdunelm/google-api-dotnet-client
that referenced
this pull request
Mar 22, 2017
This fails without PR googleapis#937, passes with it
chrisdunelm
added a commit
to chrisdunelm/google-api-dotnet-client
that referenced
this pull request
Mar 23, 2017
This fails without PR googleapis#937, passes with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this answer on the cryptography StackExchange site, there is a 1 in 400 edge case where the private key's D value will only require 255 bytes to be encoded, so we were trimming it to 255 bytes, but when .NET imports the RSA key parameters, it requires them to be aligned on 8 byte boundaries apparently.
cc @iantalarico