Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify yosys and non-yosys paths to CGGI in --mlir-to-cggi #1646

Open
asraa opened this issue Apr 2, 2025 · 0 comments
Open

Unify yosys and non-yosys paths to CGGI in --mlir-to-cggi #1646

asraa opened this issue Apr 2, 2025 · 0 comments

Comments

@asraa
Copy link
Collaborator

asraa commented Apr 2, 2025

Right now the yosys path is in --mlir-to-cggi, and the non-yosys path exists as an arith-to-cggi or arith-to-cggi-quart pass.

These should be unified and toggled under a pass option.

But doing this will require handling compilation options to exclude yosys.

copybara-service bot pushed a commit that referenced this issue Apr 2, 2025
Follow-ups:
* I'd also like to unify the arith-to-cggi (non-Yosys) paths with the `--mlir-to-cggi` but I don't know how possible it is given the compile time yosys dependency. I think I could make it work, tbh. In a follow-up #1646
* All the backends that support parallism should use the JaxiteBackendOptions, for now I just wanted to maintain parity with the codebase so only the jaxite pipeline has this option. #1645

fixes #1573

PiperOrigin-RevId: 741191624
copybara-service bot pushed a commit that referenced this issue Apr 2, 2025
Follow-ups:
* I'd also like to unify the arith-to-cggi (non-Yosys) paths with the `--mlir-to-cggi` but I don't know how possible it is given the compile time yosys dependency. I think I could make it work, tbh. In a follow-up #1646
* All the backends that support parallism should use the JaxiteBackendOptions, for now I just wanted to maintain parity with the codebase so only the jaxite pipeline has this option. #1645

fixes #1573

PiperOrigin-RevId: 741191624
copybara-service bot pushed a commit that referenced this issue Apr 2, 2025
Follow-ups:
* I'd also like to unify the arith-to-cggi (non-Yosys) paths with the `--mlir-to-cggi` but I don't know how possible it is given the compile time yosys dependency. I think I could make it work, tbh. In a follow-up #1646
* All the backends that support parallism should use the JaxiteBackendOptions, for now I just wanted to maintain parity with the codebase so only the jaxite pipeline has this option. #1645

fixes #1573

PiperOrigin-RevId: 741191624
copybara-service bot pushed a commit that referenced this issue Apr 2, 2025
Follow-ups:
* I'd also like to unify the arith-to-cggi (non-Yosys) paths with the `--mlir-to-cggi` but I don't know how possible it is given the compile time yosys dependency. I think I could make it work, tbh. In a follow-up #1646
* All the backends that support parallism should use the JaxiteBackendOptions, for now I just wanted to maintain parity with the codebase so only the jaxite pipeline has this option. #1645

fixes #1573

PiperOrigin-RevId: 741191624
copybara-service bot pushed a commit that referenced this issue Apr 2, 2025
Follow-ups:
* I'd also like to unify the arith-to-cggi (non-Yosys) paths with the `--mlir-to-cggi` but I don't know how possible it is given the compile time yosys dependency. I think I could make it work, tbh. In a follow-up #1646
* All the backends that support parallism should use the JaxiteBackendOptions, for now I just wanted to maintain parity with the codebase so only the jaxite pipeline has this option. #1645

fixes #1573

PiperOrigin-RevId: 741191624
copybara-service bot pushed a commit that referenced this issue Apr 2, 2025
Follow-ups:
* I'd also like to unify the arith-to-cggi (non-Yosys) paths with the `--mlir-to-cggi` but I don't know how possible it is given the compile time yosys dependency. I think I could make it work, tbh. In a follow-up #1646
* All the backends that support parallism should use the JaxiteBackendOptions, for now I just wanted to maintain parity with the codebase so only the jaxite pipeline has this option. #1645

fixes #1573

PiperOrigin-RevId: 743253257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant