remove trailing comment in workflow files #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, we get the following error: ``` Invalid workflow file: .github/workflows/nightly_pip_test.yml#L19 The workflow is not valid. .github/workflows/nightly_pip_test.yml (Line: 19, Col: 9): Unexpected symbol: '#'. Located at position 134 within expression: github.event_name == 'workflow_dispatch' || (github.event_name == 'schedule' && github.repository == 'google-ai-edge/ai-edge-torch') # don't run in forks. ```
|
I'm going to merge without code reviews to get the change in so that I can verify manually and also see the results of the nightly run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15 was attempting to prevent nightly workflows from running in forks.
However, the yaml was incorrectly formatted, which gave the following error (workflow_dispatch log):
This PR is removing the trailing comment and has been verified to work by running the workflow via dispatch from my branch in my fork (log).
BUG=fix broken workflow.