Skip to content

Do not run nightly workflows on forks. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2024

Conversation

advaitjain
Copy link
Contributor

This change can't really be tested until:

  • it is merged: to make sure nothing breaks for the upstream repo
  • forks update to upstream/main: to confirm that workflows are not triggered in forks.

BUG=cleanup github workflows.

This change can't really be tested until:
 * it is merged: to make sure nothing breaks for the upstream repo
 * forks update to upstream/main: to confirm that workflows are not
   triggered in forks.

BUG=cleanup github workflows.
@advaitjain advaitjain requested a review from chunnienc as a code owner May 25, 2024 06:30
@advaitjain advaitjain enabled auto-merge May 25, 2024 06:31
@advaitjain advaitjain added this pull request to the merge queue May 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 25, 2024
@advaitjain advaitjain added this pull request to the merge queue May 25, 2024
@chunnienc
Copy link
Collaborator

chunnienc commented May 25, 2024

I thought workflows are disabled by default in github forked repo, and fork owner can disable per-workflow in their settings after enabling the feature. Maybe better for me to understand what issues you saw for this.

Merged via the queue into google-ai-edge:main with commit 329c576 May 25, 2024
10 checks passed
@advaitjain advaitjain deleted the no-nightly-on-forks branch May 25, 2024 17:15
@advaitjain
Copy link
Contributor Author

I should have provided more context with the PR.

Workflows appear to be enabled by default in forks. For example: https://github.com/advaitjain/ai-edge-torch/actions

Anyone forking does have the option of disabling then, but that isn't great either. It's an additional step that can easily be overlooked (as I did). And I might want to test some workflow in my fork.

The approach from this PR is what we use with TensorFlow as well.

@chunnienc
Copy link
Collaborator

The message I saw in the actions page in my fork repo is this though (https://github.com/chunnienc/ai-edge-torch/actions):

Workflows aren’t being run on this forked repository
Because this repository contained workflow files when it was forked, we have disabled them from running on this fork. Make sure you understand the configured workflows and their expected usage before enabling Actions on this repository.

I think this change is fine as it won't affect our dev flow and tensorflow uses this approach. Let's proceed with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants