Skip to content

Found a bug in ForInfoListT object, closes #1766 #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GillesDuvert
Copy link
Contributor

contrary to its intent, the loop number did not start at 0 but at 32 (the initialized default size), and would be constantly increasing in size at each new level of nested loop (remember, ForInfoListT was designed exactly for the contrary!). May even had an incidence on the loop speed.

For the record, using a simpler std::vector would be a lot less worry but would crash when the type of the loop iterator would change during the loop, which happens (see #1540).

…number did not start at 0 but at 32 (the initialized defulat size), and would be constantly increasing in size at each new level of nested loop. May even had an incidence on the loop speed.
@GillesDuvert GillesDuvert changed the title Found a bug in ForInfoListT object Found a bug in ForInfoListT object, closes #1766 Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 42.66%. Comparing base (1251608) to head (ebfa961).
Report is 4 commits behind head on master.

Files Patch % Lines
src/envt.hpp 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1778      +/-   ##
==========================================
- Coverage   42.70%   42.66%   -0.05%     
==========================================
  Files         361      361              
  Lines       97331    97334       +3     
  Branches    19928    19928              
==========================================
- Hits        41570    41526      -44     
- Misses      55761    55808      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant