-
-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: help popup display viewing progress #2388
Conversation
Thanks for looking into this. The gitui idiomatic way to show progress on a vertical scroll though is using a scrollbar. so I would suggest we integrate that here too. feel free to join our discord to discuss there things upfront in the future to not waste any effort. |
@extrawurst I'll try to add a scrollbar on the right, similar to the one in a browser.:) |
Browser? Just use the same code we use everywhere else do scroll bars in for example the log tab |
@extrawurst Have Done! |
looking good! i wonder why you have different formatting - lets see what the ci says about that edit: it fails on the formatting. please make sure to use the latest rust stable |
My bad, my local environment was on an unstable version. I switched to the stable version of Rust, and cargo clippy works fine. |
Thanks for your contribution |
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [extrawurst/gitui](https://github.com/extrawurst/gitui) | minor | `v0.26.3` -> `v0.27.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>extrawurst/gitui (extrawurst/gitui)</summary> ### [`v0.27.0`](https://github.com/extrawurst/gitui/releases/tag/v0.27.0) [Compare Source](gitui-org/gitui@v0.26.3...v0.27.0) **new: manage remotes**  ##### Breaking Changes - use default shell instead of bash on Unix-like OS \[[@​yerke](https://github.com/yerke)] ([#​2343](gitui-org/gitui#2343)) ##### Added - add popups for viewing, adding, updating and removing remotes \[[@​robin-thoene](https://github.com/robin-thoene)] ([#​2172](gitui-org/gitui#2172)) - support for `Copy Path` action in WSL \[[@​johnDeSilencio](https://github.com/johnDeSilencio)] ([#​2413](gitui-org/gitui#2413)) - help popup scrollbar \[[@​wugeer](https://github.com/wugeer)] ([#​2388](gitui-org/gitui#2388)) ##### Fixes - respect env vars like `GIT_CONFIG_GLOBAL` ([#​2298](gitui-org/gitui#2298)) - Set `CREATE_NO_WINDOW` flag when executing Git hooks on Windows ([#​2371](gitui-org/gitui#2371)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMzcuMSIsInVwZGF0ZWRJblZlciI6IjM5LjEzNy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
It changes the following:
I followed the checklist:
make check
without errorsbefore
gitui_help_popup_before.webm
after
gitui_help_popup_after.webm