Set CREATE_NO_WINDOW flag when executing Git hooks
#2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this functionality using a dev build of GitButler with the |
|
Thanks for the contribution! Can you fix the ci issues? |
|
Sure thing! |
|
@extrawurst that should fix it, I had forgotten to ensure this was a noop when you're not on Windows |
|
@extrawurst out of curiosity, do you have an idea of when the next release will be? Also, I believe the CI workflow requires your approval again. |
extrawurst
reviewed
Sep 29, 2024
|
@icorbrey since this is a separate crate i can cut a release as soon as this is merged |
|
released git2-hooks |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jan 28, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [extrawurst/gitui](https://github.com/extrawurst/gitui) | minor | `v0.26.3` -> `v0.27.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>extrawurst/gitui (extrawurst/gitui)</summary> ### [`v0.27.0`](https://github.com/extrawurst/gitui/releases/tag/v0.27.0) [Compare Source](gitui-org/gitui@v0.26.3...v0.27.0) **new: manage remotes**  ##### Breaking Changes - use default shell instead of bash on Unix-like OS \[[@​yerke](https://github.com/yerke)] ([#​2343](gitui-org/gitui#2343)) ##### Added - add popups for viewing, adding, updating and removing remotes \[[@​robin-thoene](https://github.com/robin-thoene)] ([#​2172](gitui-org/gitui#2172)) - support for `Copy Path` action in WSL \[[@​johnDeSilencio](https://github.com/johnDeSilencio)] ([#​2413](gitui-org/gitui#2413)) - help popup scrollbar \[[@​wugeer](https://github.com/wugeer)] ([#​2388](gitui-org/gitui#2388)) ##### Fixes - respect env vars like `GIT_CONFIG_GLOBAL` ([#​2298](gitui-org/gitui#2298)) - Set `CREATE_NO_WINDOW` flag when executing Git hooks on Windows ([#​2371](gitui-org/gitui#2371)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMzcuMSIsInVwZGF0ZWRJblZlciI6IjM5LjEzNy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request makes changes to accommodate GUI functionality in GitButler (see: gitbutlerapp/gitbutler#4982).
It changes the following:
CREATE_NO_WINDOWflag when executing Git hooks on Windows.I followed the checklist:
make checkwithout errors