Skip to content

Fix plugin settings for GitExtensions-v3.3.1 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2020
Merged

Fix plugin settings for GitExtensions-v3.3.1 #43

merged 2 commits into from
Jan 17, 2020

Conversation

maraf
Copy link
Member

@maraf maraf commented Jan 15, 2020 •
edited
Loading

Fixes #42.

  • Use wildcard patch version for GitExtensions.Extensibility package reference.
  • Use base constructor of GitPluginBase with boolean parameter to indicate that plugin has settings.

maraf added 2 commits January 15, 2020 21:52
@maraf
Use wildcard patch version for GitExtensions.Extensibility package re…
2c41b87 
…ference.
@maraf
Fix plugin settings for GitExtensions-v3.3.1.
0824aa9 
Use base constructor of GitPluginBase with boolean parameter
to indicate that plugin has settings.
@maraf maraf requested a review from mast-eu January 15, 2020 20:56
@ghost ghost assigned maraf Jan 15, 2020
mast-eu
mast-eu approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@mast-eu mast-eu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, this can be merged in as is.

@maraf maraf merged commit fbff15f into gitextensions:master Jan 17, 2020
@maraf
Copy link
Member Author

maraf commented Jan 17, 2020

@mast-eu Thanks.

@maraf maraf deleted the FixPluginSettings branch January 17, 2020 17:12
@mast-eu mast-eu mentioned this pull request Oct 29, 2020
Open
@mast-eu mast-eu added this to the 1.2.0 milestone Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mast-eu mast-eu mast-eu approved these changes

Assignees

@maraf maraf

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Plugin settings disappeared from GE
2 participants
@maraf @mast-eu