Skip to content

Plugin settings disappeared from GE #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maraf opened this issue Jan 15, 2020 · 2 comments · Fixed by #43
Closed

Plugin settings disappeared from GE #42

maraf opened this issue Jan 15, 2020 · 2 comments · Fixed by #43
Assignees
@maraf
Labels
area: plugin type: bug Something isn't working
Milestone
2.0.0

Comments

@maraf
Copy link
Member

maraf commented Jan 15, 2020

Based on changes from gitextensions/gitextensions#7164, we need to call base ctor with boolean parameter (true) from the Plugin.cs.
@mast-eu
Copy link
Member

mast-eu commented Jan 15, 2020

Good catch.
Do you plan to prepare a PR for it?

@mast-eu mast-eu added this to the 1.2.0 milestone Jan 15, 2020
@mast-eu mast-eu added area: plugin type: bug Something isn't working labels Jan 15, 2020
@maraf
Copy link
Member Author

maraf commented Jan 15, 2020

Do you plan to prepare a PR for it?

Yes.

@maraf maraf self-assigned this Jan 15, 2020
@maraf maraf mentioned this issue Jan 15, 2020
Merged
@maraf maraf closed this as completed in #43 Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maraf maraf

Labels
area: plugin type: bug Something isn't working
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Fix plugin settings for GitExtensions-v3.3.1 maraf/gitextensions.pluginmanager
2 participants
@maraf @mast-eu