[d3d12] Fix bug with committed resource allocation #7519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
added
the
PR: needs back-porting
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
wgpu-hal/src/dx12/suballocation.rs:372
- The change updates the mapping to using D3D12_CPU_PAGE_PROPERTY_NOT_AVAILABLE for GPU-only memory. Please confirm that this change aligns with the intended Direct3D12 API behavior for GPU-only heaps.
MemoryLocation::GpuOnly => Direct3D12::D3D12_CPU_PAGE_PROPERTY_NOT_AVAILABLE,
|
This issue was missed in my review of #7490, where |
|
☝🏻 CC @jimblandy. |
ErichDonGubler
approved these changes
Apr 11, 2025
cwfitzgerald
added a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Apr 11, 2025
Merged
ErichDonGubler
pushed a commit
that referenced
this pull request
Apr 11, 2025
cwfitzgerald
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug.