Miscellaneous improvements in the D3D12 backend #7490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+3564
to
+3565
| // One f32 per pixel, plus one u8 per pixel, with 3 bytes intermediary padding | ||
| Self::Depth32FloatStencil8 => 8, |
There was a problem hiding this comment.
thought: Sorta weird that this is padded to an alignment of 8, but others aren't. 🤔 Wish I knew more about this domain!
There was a problem hiding this comment.
This is some random bit of knowledge about how... nvidia packs these buffers, iirc. It is two elements, one f32, one u8, but with align 4 on the structure, so you get 3 bytes of padding.
ErichDonGubler
approved these changes
Apr 8, 2025
This was referenced Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Enables work on #4150
Description
This continues the refactoring of D3D12 suballocation internals started #7476. Importantly it now draws the abstraction lines in very easy to understand ways, and allows internal backend code to easily make and destroy buffers without needing to duplicate significant code.
Additionally, there are some smaller changes in here which make life in the D3D12 backend easier.
Previously when the suballocation support was false, the memory counters did nothing. Now with unified code paths, these counters are always as close as possible to accurate.
Testing
CI
Squash or Rebase?
Rebase
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.