Fix build with profiling enabled
#7509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that CI failure isn't due to my changes. |
cwfitzgerald
added
the
PR: needs back-porting
cwfitzgerald
requested changes
Apr 10, 2025
When building with `profiling/profile-with-tracy` or similar enabled, then `alloc::format` must be in scope to compile some code. This breaks the build for `wgpu-profiler` with wgpu 25.
waywardmonkeys
force-pushed
the
fix-profiling-build
branch
from
48031dd to
2df5f7e
Compare
cwfitzgerald
approved these changes
Apr 11, 2025
|
I tried bumping |
|
I'll get it out today |
cwfitzgerald
pushed a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Apr 11, 2025
Merged
ErichDonGubler
pushed a commit
that referenced
this pull request
Apr 11, 2025
cwfitzgerald
removed
the
PR: needs back-porting
Vecvec
pushed a commit
to Vecvec/wgpu
that referenced
this pull request
Apr 11, 2025
jimblandy
pushed a commit
to jimblandy/wgpu
that referenced
this pull request
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Wumpf/wgpu-profiler#95
Description
When building with
profiling/profile-with-tracyor similar enabled, thenalloc::formatmust be in scope to compile some code.This breaks the build for
wgpu-profilerwith wgpu 25.Testing
Ran
cargo clippy --tests --features profiling/profile-with-tracySquash or Rebase?
N/A
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.