Sync potel-base with master #4432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if the environment variable `SENTRY_DEBUG` would have an invalid value, such as "invalid," we would set `rv["debug"]` to `None`. However, since this value should be a boolean, it should instead be set to `False`. This change ensures that `rv["debug"]` always is a boolean. Where we previously would have set the value to `None`, we now set it to `False`. Other behavior remains unchanged. Ref https://github.com/getsentry/sentry-python/pull/4366/files#r2075294825
Regular tox update
…le (#4404) This [commit](redis/redis-py@91be4a0) in `redis-py` moved away from using the Pipeline's `command_stack` and is now using `_execution_strategy.command_queue` instead. We need to adapt to use the new command source if present. This fixes `redis-latest` in CI. --------- Co-authored-by: Daniel Szoke <[email protected]>
OTel also wraps `grpc.aio.server`, but expects the `interceptors` arg to be a list, while Sentry [turns it into a tuple](https://github.com/getsentry/sentry-python/blob/94414cdcdce2a311355967ee7b43e7035cf954ce/sentry_sdk/integrations/grpc/__init__.py#L130). Non-tuple sequences are actually only supported [starting](grpc/grpc@9699580) in grpc 1.42.0. So for older versions we need to still use a tuple. Fixes #4389
Three new versions of things that need addressing: - pytest-asyncio 1.0 [removes](https://pytest-asyncio.readthedocs.io/en/latest/reference/changelog.html#id2) the deprecated `event_loop` fixture - mypy 1.16.0 finds some new issues - [redis 6.2.0](https://github.com/redis/redis-py/releases/tag/v6.2.0): - adds the `execution_strategy` abstraction to async cluster pipelines as well, so the commands are no longer accessible directly and need to be accessed via the `strategy` - renames the `_client` attribute on async cluster pipeline to `cluster_client`
❌ 12 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
sentrivana
force-pushed
the
ivana/potel/sync-sync
branch
from
a0b8c1d to
9983288
Compare
sentrivana
force-pushed
the
ivana/potel/sync-sync
branch
from
9983288 to
a012fe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing potel/master sync