Skip to content

fix: fix ARQ integration error (#4427) #4428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025

Conversation

ninoseki
Copy link
Contributor

Fix #4427 by setting an empty list if settings_cls.cron_jobs is None.

@ninoseki ninoseki requested a review from a team as a code owner May 29, 2025 03:32
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting and fixing @ninoseki!

@sentrivana sentrivana enabled auto-merge (squash) June 2, 2025 08:31
@sentrivana sentrivana merged commit 7cf4ee4 into getsentry:master Jun 2, 2025
135 checks passed
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.60%. Comparing base (aad481d) to head (99650dd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4428      +/-   ##
==========================================
- Coverage   80.61%   80.60%   -0.01%     
==========================================
  Files         142      142              
  Lines       15982    15982              
  Branches     2729     2729              
==========================================
- Hits        12884    12883       -1     
  Misses       2241     2241              
- Partials      857      858       +1     
Files with missing lines Coverage Δ
sentry_sdk/integrations/arq.py 89.84% <ø> (ø)

... and 1 file with indirect coverage changes

@ninoseki ninoseki deleted the fix-arq-integration-error branch June 4, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARQ Integration: Cron Jobs (cron_jobs) Handling Error
2 participants