Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecations for main/gz-sim8 #1783

Merged
merged 6 commits into from
Dec 8, 2022
Merged

Remove deprecations for main/gz-sim8 #1783

merged 6 commits into from
Dec 8, 2022

Conversation

mjcarroll
Copy link
Contributor

🎉 New feature

Summary

Remove ignition headers and things that have been marked as deprecated in gz-sim8

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll
Remove deprecated headers
9d36c83 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Remove main deprecations
c5a32a9 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll self-assigned this Nov 9, 2022
@mjcarroll mjcarroll marked this pull request as ready for review December 6, 2022 17:31
azeey
azeey reviewed Dec 7, 2022
View reviewed changes
@mjcarroll
Restore missing plugin alias
98dd43e 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Remove unused modelMass
ce5b12b 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll mentioned this pull request Dec 7, 2022
Merged
azeey
azeey approved these changes Dec 7, 2022
View reviewed changes
@azeey
Copy link
Contributor

azeey commented Dec 7, 2022

codecheck is failing.

@mjcarroll
lint
dd25b33 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Copy link
Contributor Author

codecheck is failing.

arg dd25b33

@mjcarroll mjcarroll merged commit 01d9d94 into main Dec 8, 2022
@mjcarroll mjcarroll deleted the mjcarroll/main_deprecations branch December 8, 2022 20:30
@iche033 iche033 added the 🎵 harmonic Gazebo Harmonic label Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methylDragon methylDragon methylDragon left review comments

@azeey azeey azeey approved these changes

@ahcorde ahcorde ahcorde approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees

@mjcarroll mjcarroll

Labels
🎵 harmonic Gazebo Harmonic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mjcarroll @azeey @ahcorde @methylDragon @iche033