6 ➡️ 7 (main) #1293
Merged
6 ➡️ 7 (main) #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Jorge Perez <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
* Support battery draining start via topics Signed-off-by: Nate Koenig <[email protected]> * Added more documentation and a todo item Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
* Make tests run as fast as possible (#1194) Signed-off-by: Louise Poubel <[email protected]> * [Dome] Make tests run as fast as possible (#1250) Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Martin Pecka <[email protected]>
Signed-off-by: William Lew <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
…linear and angular separately. (#1229) Signed-off-by: Roni Kreinin <[email protected]> Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: harshmahesheka <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
* Surface plugin. Signed-off-by: Carlos Agüero <[email protected]> Co-authored-by: Ian Chen <[email protected]>
* Adding angular acceleration. Signed-off-by: Carlos Agüero <[email protected]> * add test Signed-off-by: Ian Chen <[email protected]> * update link api tutorial Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Ian Chen <[email protected]>
Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Jorge Perez <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
chapulina
added
the
needs upstream release
Codecov Report
@@ Coverage Diff @@
## main #1293 +/- ##
==========================================
+ Coverage 62.01% 62.32% +0.31%
==========================================
Files 276 278 +2
Lines 23020 23242 +222
==========================================
+ Hits 14276 14486 +210
- Misses 8744 8756 +12
Continue to review full report at Codecov.
|
Signed-off-by: Tomoya.Fujita <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
The buoyancy engine should stop working when it crosses the water surface. This PR adds a <surface> tag which stops the buoyancy engine from exerting an upward force when the vehicle is surfacing. Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
chapulina
added a commit
that referenced
this pull request
Jan 21, 2022
Signed-off-by: Louise Poubel <[email protected]>
chapulina
force-pushed
the
chapulina/6_to_7
branch
from
fb7778c to
633f687
Compare
This typo appears to be an artifact of some earlier copy-pastes. It sometimes causes the SceneBroadcaster to crash in unoptimized builds. Signed-off-by: sicongw <[email protected]>
I discovered that the `<topic>` parameter has not been documented in the docstring. This mini-PR adds the docs for it. Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
chapulina
force-pushed
the
chapulina/6_to_7
branch
from
633f687 to
4e5faf1
Compare
j-rivero
reviewed
Jan 25, 2022
|
CMake warnings in Ubuntu and Windows, probably out of the scope of this PR. I think that the failing test in Ubuntu is also unrelated. |
Yeah the Ubuntu ones should be fixed by ign-gui releases. Windows is in the works, i.e. #1299
Yup, that's been flaky |
j-rivero
approved these changes
Jan 25, 2022
chapulina
removed
the
needs upstream release
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
ign-gazebo6tomainNote to maintainers: Remember to Merge with commit (not squash-merge or rebase)