Fix typo in EntityComponentManager

[sicongw]

This typo appears to be an artifact of some earlier copy-pastes. It sometimes causes the SceneBroadcaster to crash in unoptimized builds.

Signed-off-by: Sicong (Anson) Wang [email protected]

[chapulina]

Wow nice catch, thanks for the PR! Would you be able to sign your commit for the DCO checker?

[sicongw]

Thank you for the quick review, @chapulina. If I understand correctly, the DCO check asks me to end my commit message with "Signed-off-by: Name [email protected]", which I already did. Am I missing something?

[codecov]

Codecov Report

Merging #1304 (be68bbf) into ign-gazebo6 (9dee519) will not change coverage.
The diff coverage is 100.00%.

❗ Current head be68bbf differs from pull request most recent head c801880. Consider uploading reports for the commit c801880 to get more accurate results

@@             Coverage Diff              @@
##           ign-gazebo6    #1304   +/-   ##
============================================
  Coverage        62.25%   62.25%           
============================================
  Files              278      278           
  Lines            23203    23203           
============================================
  Hits             14444    14444           
  Misses            8759     8759           

Impacted Files	Coverage Δ
src/EntityComponentManager.cc	88.26% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dee519...c801880. Read the comment docs.

[chapulina]

If I understand correctly, the DCO check asks me to end my commit message with "Signed-off-by: Name [email protected]", which I already did. Am I missing something?

The hint can be found if you click on the DCO Details below:

Commit sha: be68bbf, Author: sicongw, Committer: GitHub; Expected "sicongw [email protected]", but got "Sicong "Anson" Wang [email protected]".

There's a mismatch between your GitHub username and email, and your signature. You should be able to edit those in your settings.

[sicongw]

If I understand correctly, the DCO check asks me to end my commit message with "Signed-off-by: Name [email protected]", which I already did. Am I missing something?

The hint can be found if you click on the DCO Details below:

Commit sha: be68bbf, Author: sicongw, Committer: GitHub; Expected "sicongw [email protected]", but got "Sicong "Anson" Wang [email protected]".

There's a mismatch between your GitHub username and email, and your signature. You should be able to edit those in your settings.

Ah, thank you for pointing that out. I have updated my GitHub profile to match my signature. It seems I don't have the permission to re-run the checks -- I don't see the Re-run jobs button in the Action tab per the CI guide. Could you re-trigger the checks please?

[chapulina]

I reran it, but it doesn't seem to have picked it up 😕 Maybe if you force-push again? Thanks for iterating 🙇‍♀️

[sicongw]

DCO is now passing. There seems to be some CI failures/flakiness. Would appreciate your triggering reruns for those. Thank you!

[chapulina]

Thanks for iterating 👍 There are no new CI failures.

[osrf-triage]

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1