Skip to content

Non desired window opening alongside ignition GUI #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 28, 2021

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Summary

Fix gazebosim/gz-gui#291

Requires a PR in ign-gui6 gazebosim/gz-gui#292

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #1063 (8173b16) into main (a452a01) will decrease coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1063      +/-   ##
==========================================
- Coverage   64.06%   64.06%   -0.01%     
==========================================
  Files         255      255              
  Lines       19963    19967       +4     
==========================================
+ Hits        12790    12791       +1     
- Misses       7173     7176       +3     
Impacted Files Coverage Δ
include/ignition/gazebo/rendering/RenderUtil.hh 100.00% <ø> (ø)
src/rendering/RenderUtil.cc 36.31% <25.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a452a01...8173b16. Read the comment docs.

@chapulina chapulina added beta Targeting beta release of upcoming collection rendering Involves Ignition Rendering bug Something isn't working labels Sep 29, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging it now, but the fix will only take effect once ign-rendering is merged.

@chapulina chapulina merged commit cff085e into main Sep 30, 2021
@chapulina chapulina deleted the ahcorde/fix/second_window branch September 30, 2021 22:34
WilliamLewww pushed a commit to WilliamLewww/ign-gazebo that referenced this pull request Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection bug Something isn't working 🏯 fortress Ignition Fortress rendering Involves Ignition Rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants