Non desired window opening alongside ignition GUI (gazebosim#1063)

Signed-off-by: ahcorde <[email protected]>
Signed-off-by: William Lew <[email protected]>

Author: ahcorde

include/ignition/gazebo/rendering/RenderUtil.hh

@@ -123,6 +123,10 @@ inline namespace IGNITION_GAZEBO_VERSION_NAMESPACE {
     /// \param[in] _enable True to use the current GL context
     public: void SetUseCurrentGLContext(bool _enable);
 
+    /// \brief Set the Window ID
+    /// \param[in] _winID Window ID
+    public: void SetWinID(const std::string &_winID);
+
     /// \brief Set whether to create rendering sensors
     /// \param[in] _enable True to create rendering sensors
     /// \param[in] _createSensorCb Callback function for creating the sensors

src/gui/plugins/scene3d/Scene3D.cc

@@ -1871,6 +1871,9 @@ void IgnRenderer::Initialize()
   if (this->initialized)
     return;
 
+  this->dataPtr->renderUtil.SetWinID(std::to_string(
+    ignition::gui::App()->findChild<ignition::gui::MainWindow *>()->
+      QuickWindow()->winId()));
   this->dataPtr->renderUtil.SetUseCurrentGLContext(true);
   this->dataPtr->renderUtil.Init();
 

src/rendering/RenderUtil.cc

@@ -143,6 +143,9 @@ class ignition::gazebo::RenderUtilPrivate
   /// \brief Flag to indicate if the current GL context should be used
   public: bool useCurrentGLContext = false;
 
+  /// \brief Window ID handle
+  public: std::string winID = "";
+
   /// \brief New scenes to be created
   public: std::vector<sdf::Scene> newScenes;
 
@@ -1704,6 +1707,7 @@ void RenderUtil::Init()
     params["useCurrentGLContext"] = "1";
   if (this->dataPtr->isHeadlessRendering)
     params["headless"] = "1";
+  params["winID"] = this->dataPtr->winID;
   this->dataPtr->engine = rendering::engine(this->dataPtr->engineName, params);
   if (!this->dataPtr->engine)
   {
@@ -1823,6 +1827,12 @@ void RenderUtil::SetUseCurrentGLContext(bool _enable)
   this->dataPtr->useCurrentGLContext = _enable;
 }
 
+/////////////////////////////////////////////////
+void RenderUtil::SetWinID(const std::string &_winID)
+{
+  this->dataPtr->winID = _winID;
+}
+
 /////////////////////////////////////////////////
 void RenderUtil::SetEnableSensors(bool _enable,
     std::function<std::string(const gazebo::Entity &, const sdf::Sensor &,