[ogre1.x] Add support for wide angle camera #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
…ng black screen Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
8 tasks
Signed-off-by: Ian Chen <[email protected]>
8 tasks
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
scpeters
reviewed
Nov 18, 2021
|
|
||
| /// \internal | ||
| /// \brief Private data pointer | ||
| private: std::unique_ptr<CameraLensPrivate> dataPtr; |
There was a problem hiding this comment.
I think we could add ignition-utils as a dependency so we can use the ImplPtr? I'll open an issue to do this in parallel, without blocking
There was a problem hiding this comment.
this dependency has been added in #492, so I recommend using ImplPtr in this new class
There was a problem hiding this comment.
switched to use ImplPtr in 21d9f79
This was referenced Nov 18, 2021
Merged
ahcorde
requested changes
Nov 18, 2021
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #490 +/- ##
==========================================
- Coverage 53.47% 52.22% -1.25%
==========================================
Files 199 203 +4
Lines 19745 20215 +470
==========================================
Hits 10558 10558
- Misses 9187 9657 +470
Continue to review full report at Codecov.
|
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
WilliamLewww
approved these changes
Nov 29, 2021
Signed-off-by: Ian Chen <[email protected]>
ahcorde
approved these changes
Dec 3, 2021
Signed-off-by: Ian Chen <[email protected]>
…ign-rendering into wide_angle_camera_ogre
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Ported the wide angle camera feature from gazebo-classic. Added the base classes and ogre 1.x implementation.
Test it
Added a wide_angle_camera integration test and a demo.
Run the integration test with
ogrerender engine from your colcon workspace:Build and run the wide_angle_camera demo:
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge