This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Add missing header files #3227
Merged
Add missing header files #3227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Include specific math headers instead of math.hh to speed up compilation. Signed-off-by: Steve Peters <[email protected]>
|
gazebosim/sdformat#1044 has been closed, but these changes are still valid, so I will leave this open for review |
Missed the original discussion but Louise was right about not removing a header from an stable released series of sdformat. The PR looks good to me, CI is happy, I'm happy too. |
j-rivero
approved these changes
Sep 6, 2022
|
There is a problem on Windows conda-forge but I'm pretty sure it is not related to this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some header files are proposed for removal from
sdf/Param.hhin gazebosim/sdformat#1044. While testing that branch with gazebo11, I noticed some compilation failures in files that use objects without including the associated header file. I've added missing header files for manyignition/math/*includes in c20bb21. It is more than enough to fix compilation, though it is not fully exhaustive.I made two other small changes as well:
ignition/math.hhin two.ccfiles with the specific math header files that are needed to reduce compilation time. Since these are.ccfiles, there should not be an effect on any downstream code.