update slots and signals to match #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sssoleileraaa
requested review from
kushaldas and
redshiftzero
as code owners
sssoleileraaa
force-pushed
the
766-fix
branch
from
c14d760 to
3964cb7
Compare
sssoleileraaa
changed the title
sssoleileraaa
force-pushed
the
766-fix
branch
from
3964cb7 to
9d32c7e
Compare
sssoleileraaa
commented
Feb 5, 2020
redshiftzero
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #771
Fixes #774
Fixes #769
Fixes #766
I recommend testing on Qubes to be able to see slower state changes. Follow each bug's STR to verify that it no longer happens and for issue #771 just make sure slots expect the right arguments from their respective signals.
Still need to add tests