Skip to content

New gas representation #3054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 17, 2025
Merged

New gas representation #3054

merged 9 commits into from
Mar 17, 2025

Conversation

THenry14
Copy link
Collaborator

@THenry14 THenry14 commented Mar 6, 2025 •
edited
Loading

Related to #2977

This PR stack aims to add support for new resource tracking (sierra-gas) and new gas representation (GasVector triplet instead of single l1 gas value).

-- (#3049) Add sierra gas tracking
-- (#3050) Run already existing tests with CairoSteps set explicitly
-- (#3051) Add support for sierra gas in --detailed-resources
-- (#3052) Add support for sierra gas in --save-trace-data
-- (#3053) Add sierra version assertion
--> (This PR) Introduce new gas representation
-- (#3055) Add gas tests for sierra-gas tracking
-- (#3056) Update docs with sierra-gas related changes

@THenry14 THenry14 changed the base branch from master to szymczyk/sg-5-sierra-assertion March 6, 2025 08:02
@THenry14 THenry14 changed the title Szymczyk/sg 6 new gas representation New gas representation Mar 6, 2025
This was referenced Mar 6, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@THenry14 THenry14 marked this pull request as ready for review March 6, 2025 08:53
@THenry14 THenry14 requested a review from a team as a code owner March 6, 2025 08:53
@THenry14 THenry14 requested review from franciszekjob, kkawula and cptartur and removed request for a team March 6, 2025 08:53
@THenry14
Copy link
Collaborator Author

THenry14 commented Mar 6, 2025

🔴
Please take a look specifically at cheat_max_fee cheatcode while reviewing this PR - I have not touched this cheatcode at all, and am not sure if it should just work or perhaps I have missed something crucial here that is not causing tests to explode.

@THenry14 THenry14 force-pushed the szymczyk/sg-5-sierra-assertion branch from a91abae to 3b9cb2f Compare March 6, 2025 13:04
@THenry14 THenry14 force-pushed the szymczyk/sg-6-new-gas-representation branch 2 times, most recently from 2e83e23 to a0e19c5 Compare March 6, 2025 13:06
ksew1
ksew1 reviewed Mar 10, 2025
View reviewed changes
@THenry14 THenry14 force-pushed the szymczyk/sg-5-sierra-assertion branch from 3b9cb2f to fb65d80 Compare March 10, 2025 12:35
@THenry14 THenry14 force-pushed the szymczyk/sg-6-new-gas-representation branch from a0e19c5 to a50a267 Compare March 10, 2025 12:36
@THenry14 THenry14 force-pushed the szymczyk/sg-5-sierra-assertion branch from fb65d80 to 51c4c47 Compare March 10, 2025 12:52
@THenry14 THenry14 force-pushed the szymczyk/sg-6-new-gas-representation branch from a50a267 to f134013 Compare March 10, 2025 12:52
cptartur
cptartur reviewed Mar 10, 2025
View reviewed changes
ddoktorski
ddoktorski reviewed Mar 10, 2025
View reviewed changes
@THenry14 THenry14 force-pushed the szymczyk/sg-6-new-gas-representation branch from f134013 to bfbdafc Compare March 11, 2025 13:08
@THenry14 THenry14 requested a review from cptartur March 14, 2025 08:52
ddoktorski
ddoktorski reviewed Mar 14, 2025
View reviewed changes
@THenry14 THenry14 requested a review from ddoktorski March 14, 2025 14:53
ksew1
ksew1 reviewed Mar 14, 2025
View reviewed changes
cptartur
cptartur reviewed Mar 14, 2025
View reviewed changes
@THenry14 THenry14 requested review from cptartur and ksew1 March 14, 2025 16:50
ddoktorski
ddoktorski reviewed Mar 17, 2025
View reviewed changes
cptartur
cptartur approved these changes Mar 17, 2025
View reviewed changes
@THenry14 THenry14 mentioned this pull request Mar 17, 2025
Open
@THenry14 THenry14 force-pushed the szymczyk/sg-5-sierra-assertion branch from d249b7c to d9c2897 Compare March 17, 2025 17:45
@THenry14 THenry14 force-pushed the szymczyk/sg-6-new-gas-representation branch from 2aa0ec7 to 9f7d06b Compare March 17, 2025 17:45
THenry14 added a commit that referenced this pull request Mar 17, 2025
@THenry14
Update docs regarding sierra-gas tracking (#3056)
9c5dc3f 
Related to #2977

This PR stack aims to add support for new resource tracking (sierra-gas)
and new gas representation (GasVector triplet instead of single l1 gas
value).

-- (#3049) Add sierra
gas tracking
-- (#3050) Run
already existing tests with CairoSteps set explicitly
-- (#3051) Add
support for sierra gas in `--detailed-resources`
-- (#3052) Add
support for sierra gas in `--save-trace-data`
-- (#3053) Add sierra
version assertion
-- (#3054) Introduce
new gas representation
-- (#3055) Add gas
tests for sierra-gas tracking
--> (This PR) Update docs with sierra-gas related changes
@THenry14
Add gas tests for sierra-gas tracked resource (#3055)
63f6e2a 
Related to #2977

This PR stack aims to add support for new resource tracking (sierra-gas)
and new gas representation (GasVector triplet instead of single l1 gas
value).

-- (#3049) Add sierra
gas tracking
-- (#3050) Run
already existing tests with CairoSteps set explicitly
-- (#3051) Add
support for sierra gas in `--detailed-resources`
-- (#3052) Add
support for sierra gas in `--save-trace-data`
-- (#3053) Add sierra
version assertion
-- (#3054) Introduce
new gas representation
--> (This PR) Add gas tests for sierra-gas tracking
-- (#3056) Update
docs with sierra-gas related changes
@THenry14 THenry14 merged commit 88c337d into szymczyk/sg-5-sierra-assertion Mar 17, 2025
3 of 22 checks passed
@THenry14 THenry14 deleted the szymczyk/sg-6-new-gas-representation branch March 17, 2025 17:48
THenry14 added a commit that referenced this pull request Mar 17, 2025
@THenry14
Add sierra assertion when tracking sierra gas (#3053)
97982a2 
Related to #2977

This PR stack aims to add support for new resource tracking (sierra-gas)
and new gas representation (GasVector triplet instead of single l1 gas
value).

-- (#3049) Add sierra
gas tracking
-- (#3050) Run
already existing tests with CairoSteps set explicitly
-- (#3051) Add
support for sierra gas in `--detailed-resources`
-- (#3052) Add
support for sierra gas in `--save-trace-data`
--> (This PR) Add sierra version assertion
-- (#3054) Introduce
new gas representation
-- (#3055) Add gas
tests for sierra-gas tracking
-- (#3056) Update
docs with sierra-gas related changes
THenry14 added a commit that referenced this pull request Mar 17, 2025
@THenry14
Add sierra gas resource to trace file (#3052)
5c5c18e 
Related to #2977

This PR stack aims to add support for new resource tracking (sierra-gas)
and new gas representation (GasVector triplet instead of single l1 gas
value).

-- (#3049) Add sierra
gas tracking
-- (#3050) Run
already existing tests with CairoSteps set explicitly
-- (#3051) Add
support for sierra gas in `--detailed-resources`
--> (This PR) Add support for sierra gas in `--save-trace-data`
-- (#3053) Add sierra
version assertion
-- (#3054) Introduce
new gas representation
-- (#3055) Add gas
tests for sierra-gas tracking
-- (#3056) Update
docs with sierra-gas related changes
THenry14 added a commit that referenced this pull request Mar 17, 2025
@THenry14
Adjust --detailed-resources to sierra-gas tracking (#3051)
4ecb33f 
Related to #2977

This PR stack aims to add support for new resource tracking (sierra-gas)
and new gas representation (GasVector triplet instead of single l1 gas
value).

-- (#3049) Add sierra
gas tracking
-- (#3050) Run
already existing tests with CairoSteps set explicitly
-- (This PR) Add support for sierra gas in `--detailed-resources`
-- (#3052) Add
support for sierra gas in `--save-trace-data`
-- (#3053) Add sierra
version assertion
-- (#3054) Introduce
new gas representation
-- (#3055) Add gas
tests for sierra-gas tracking
-- (#3056) Update
docs with sierra-gas related changes
THenry14 added a commit that referenced this pull request Mar 17, 2025
@THenry14
Run forge tests with cairo steps explicitly set in tests (#3050)
03166da 
Related to #2977

This PR stack aims to add support for new resource tracking (sierra-gas)
and new gas representation (GasVector triplet instead of single l1 gas
value).

-- (#3049) Add sierra
gas tracking
--> (This PR) Run already existing tests with CairoSteps set explicitly
-- (#3051) Add
support for sierra gas in `--detailed-resources`
-- (#3052) Add
support for sierra gas in `--save-trace-data`
-- (#3053) Add sierra
version assertion
-- (#3054) Introduce
new gas representation
-- (#3055) Add gas
tests for sierra-gas tracking
-- (#3056) Update
docs with sierra-gas related changes
github-merge-queue bot pushed a commit that referenced this pull request Mar 17, 2025
@THenry14
Add sierra gas resource tracking (#3049)
b0b17ca 
Closes #2977

This PR stack aims to add support for new resource tracking (sierra-gas)
and new gas representation (GasVector triplet instead of single l1 gas
value).

--> (This PR) Add sierra gas tracking
-- (#3050) Run
already existing tests with CairoSteps set explicitly
-- (#3051) Add
support for sierra gas in `--detailed-resources`
-- (#3052) Add
support for sierra gas in `--save-trace-data`
-- (#3053) Add sierra
version assertion
-- (#3054) Introduce
new gas representation
-- (#3055) Add gas
tests for sierra-gas tracking
-- (#3056) Update
docs with sierra-gas related changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski ddoktorski left review comments

@cptartur cptartur cptartur approved these changes

@ksew1 ksew1 ksew1 approved these changes

@franciszekjob franciszekjob Awaiting requested review from franciszekjob franciszekjob was automatically assigned from foundry-rs/starknet-foundry

@kkawula kkawula Awaiting requested review from kkawula kkawula was automatically assigned from foundry-rs/starknet-foundry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@THenry14 @ddoktorski @cptartur @ksew1