Run forge tests with cairo steps explicitly set in tests #3050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 6, 2025
Merged
THenry14
requested review from
ddoktorski,
kkawula and
cptartur
and removed request for
a team
THenry14
force-pushed
the
szymczyk/sg-1-add-sierra-gas-tracking
branch
from
56e4694 to
6169638
Compare
THenry14
force-pushed
the
szymczyk/sg-2-run-tests-with-cairo-steps-explicitly
branch
from
393a3c5 to
ad52dbe
Compare
cptartur
approved these changes
Mar 10, 2025
ksew1
approved these changes
Mar 10, 2025
Some do, but mainly this just lays ground for #3055, where you get different cost depending on tracked resource |
THenry14
force-pushed
the
szymczyk/sg-2-run-tests-with-cairo-steps-explicitly
branch
from
ad52dbe to
0d2a153
Compare
ddoktorski
approved these changes
Mar 12, 2025
THenry14
force-pushed
the
szymczyk/sg-1-add-sierra-gas-tracking
branch
from
d7fd230 to
40ca54d
Compare
THenry14
force-pushed
the
szymczyk/sg-2-run-tests-with-cairo-steps-explicitly
branch
from
0d2a153 to
87075d6
Compare
THenry14
added a commit
that referenced
this pull request
Mar 17, 2025
Related to #2977 This PR stack aims to add support for new resource tracking (sierra-gas) and new gas representation (GasVector triplet instead of single l1 gas value). -- (#3049) Add sierra gas tracking -- (#3050) Run already existing tests with CairoSteps set explicitly -- (#3051) Add support for sierra gas in `--detailed-resources` -- (#3052) Add support for sierra gas in `--save-trace-data` -- (#3053) Add sierra version assertion -- (#3054) Introduce new gas representation -- (#3055) Add gas tests for sierra-gas tracking --> (This PR) Update docs with sierra-gas related changes
THenry14
added a commit
that referenced
this pull request
Mar 17, 2025
Related to #2977 This PR stack aims to add support for new resource tracking (sierra-gas) and new gas representation (GasVector triplet instead of single l1 gas value). -- (#3049) Add sierra gas tracking -- (#3050) Run already existing tests with CairoSteps set explicitly -- (#3051) Add support for sierra gas in `--detailed-resources` -- (#3052) Add support for sierra gas in `--save-trace-data` -- (#3053) Add sierra version assertion -- (#3054) Introduce new gas representation --> (This PR) Add gas tests for sierra-gas tracking -- (#3056) Update docs with sierra-gas related changes
THenry14
added a commit
that referenced
this pull request
Mar 17, 2025
Related to #2977 This PR stack aims to add support for new resource tracking (sierra-gas) and new gas representation (GasVector triplet instead of single l1 gas value). -- (#3049) Add sierra gas tracking -- (#3050) Run already existing tests with CairoSteps set explicitly -- (#3051) Add support for sierra gas in `--detailed-resources` -- (#3052) Add support for sierra gas in `--save-trace-data` -- (#3053) Add sierra version assertion --> (This PR) Introduce new gas representation -- (#3055) Add gas tests for sierra-gas tracking -- (#3056) Update docs with sierra-gas related changes
THenry14
added a commit
that referenced
this pull request
Mar 17, 2025
Related to #2977 This PR stack aims to add support for new resource tracking (sierra-gas) and new gas representation (GasVector triplet instead of single l1 gas value). -- (#3049) Add sierra gas tracking -- (#3050) Run already existing tests with CairoSteps set explicitly -- (#3051) Add support for sierra gas in `--detailed-resources` -- (#3052) Add support for sierra gas in `--save-trace-data` --> (This PR) Add sierra version assertion -- (#3054) Introduce new gas representation -- (#3055) Add gas tests for sierra-gas tracking -- (#3056) Update docs with sierra-gas related changes
THenry14
added a commit
that referenced
this pull request
Mar 17, 2025
Related to #2977 This PR stack aims to add support for new resource tracking (sierra-gas) and new gas representation (GasVector triplet instead of single l1 gas value). -- (#3049) Add sierra gas tracking -- (#3050) Run already existing tests with CairoSteps set explicitly -- (#3051) Add support for sierra gas in `--detailed-resources` --> (This PR) Add support for sierra gas in `--save-trace-data` -- (#3053) Add sierra version assertion -- (#3054) Introduce new gas representation -- (#3055) Add gas tests for sierra-gas tracking -- (#3056) Update docs with sierra-gas related changes
Related to #2977 This PR stack aims to add support for new resource tracking (sierra-gas) and new gas representation (GasVector triplet instead of single l1 gas value). -- (#3049) Add sierra gas tracking -- (#3050) Run already existing tests with CairoSteps set explicitly -- (This PR) Add support for sierra gas in `--detailed-resources` -- (#3052) Add support for sierra gas in `--save-trace-data` -- (#3053) Add sierra version assertion -- (#3054) Introduce new gas representation -- (#3055) Add gas tests for sierra-gas tracking -- (#3056) Update docs with sierra-gas related changes
THenry14
merged commit 03166da
into
szymczyk/sg-1-add-sierra-gas-tracking
0 of 12 checks passed
THenry14
deleted the
szymczyk/sg-2-run-tests-with-cairo-steps-explicitly
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 17, 2025
Closes #2977 This PR stack aims to add support for new resource tracking (sierra-gas) and new gas representation (GasVector triplet instead of single l1 gas value). --> (This PR) Add sierra gas tracking -- (#3050) Run already existing tests with CairoSteps set explicitly -- (#3051) Add support for sierra gas in `--detailed-resources` -- (#3052) Add support for sierra gas in `--save-trace-data` -- (#3053) Add sierra version assertion -- (#3054) Introduce new gas representation -- (#3055) Add gas tests for sierra-gas tracking -- (#3056) Update docs with sierra-gas related changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2977
This PR stack aims to add support for new resource tracking (sierra-gas) and new gas representation (GasVector triplet instead of single l1 gas value).
-- (#3049) Add sierra gas tracking
--> (This PR) Run already existing tests with CairoSteps set explicitly
-- (#3051) Add support for sierra gas in
--detailed-resources-- (#3052) Add support for sierra gas in
--save-trace-data-- (#3053) Add sierra version assertion
-- (#3054) Introduce new gas representation
-- (#3055) Add gas tests for sierra-gas tracking
-- (#3056) Update docs with sierra-gas related changes