change(modal): allows image description flexbox to take available space #3269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flex item of image description in modal doesn't take available space that limits it's child elements from displaying full-width when necessary.
lubber-de
added
type/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The flex item for the image description in the modal does not utilize the available space, which restricts its child elements from being displayed at full width when required.
It results in considerable adverse layout impacts when an element, such as a form is displayed inside the description container. The form components, including input fields, fail to utilize the available space, causing the form to appear constricted within the modal.
This PR modifies this behavior of the flexbox item for the description, enabling it to be flexible and allowing it to grow and shrink.
So, the description container will grow in the absence of sibling elements following it, allowing the child elements within to take available space and display in a full-width format, particularly in the context of the form layout.
Testcase
Before: https://jsfiddle.net/f9uwm0ov/
After: https://jsfiddle.net/ko2in/d7o8fjak/
Screenshot
Before
After
Closes
#3268