Skip to content

[modal] form in modal with image doesn’t utilise full width #3268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamessampford opened this issue May 11, 2025 · 2 comments
Open

[modal] form in modal with image doesn’t utilise full width #3268

jamessampford opened this issue May 11, 2025 · 2 comments
Labels
tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build type/bug Any issue which is a bug or PR which fixes a bug
Milestone

Comments

@jamessampford
Copy link
Contributor

Bug Report

If a form is included in a modal with an image to the side, the form fields do not use all the available space

By changing flex to flex: 1 0 auto on description class, it seems to then use the full width, but not sure if better solution exists or if this breaks something else

Testcase

https://jsfiddle.net/f9uwm0ov/

Version

2.9.4

@jamessampford jamessampford added type/bug Any issue which is a bug or PR which fixes a bug state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged labels May 11, 2025
@ko2in ko2in removed the state/awaiting-triage Any issues or pull requests which haven't yet been triaged label May 12, 2025
@ko2in
Copy link
Member

ko2in commented May 12, 2025

I took a quick look and I guess it's OK to allow description container to use the remaining space.
It gives the same result as long as the image container uses variation for it's size.

Even if it doesn't, then the description container is going to use the remaining space after the image container which is the same as current implementation.

I'll submit a PR for this.

@ko2in
Copy link
Member

ko2in commented May 12, 2025

Fixed in #3269

@ko2in ko2in added state/has-pr An issue which has a related PR open and removed state/awaiting-investigation Anything which needs more investigation labels May 13, 2025
@lubber-de lubber-de added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/has-pr An issue which has a related PR open labels May 15, 2025
@lubber-de lubber-de added this to the 2.10.0 milestone May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

No branches or pull requests

3 participants