Skip to content

feat(lint): fix multiple rare eslint errors #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 12, 2022

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Dec 11, 2022

Modernize code using eslint advisory introduced in GH-2596. This PR focuses on fixing multiple rare rules, done in one PR, as otherwise there will be only a few LOC changed per separate PR.

Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... you are on fire :D

@lubber-de lubber-de changed the title Fix multiple rare eslint errors feat(lint): fix multiple rare eslint errors Dec 12, 2022
@lubber-de lubber-de merged commit 7498343 into fomantic:develop Dec 12, 2022
@lubber-de lubber-de added this to the 2.9.1 milestone Dec 12, 2022
@mvorisek mvorisek deleted the airbnb_part3 branch December 12, 2022 11:10
@lubber-de lubber-de added type/feat Any feature requests or improvements lang/javascript Anything involving JavaScript type/ci Anything related to CI/CD labels Dec 12, 2022
@lubber-de lubber-de added the type/lint eslint / stylelint related changes only label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript type/ci Anything related to CI/CD type/feat Any feature requests or improvements type/lint eslint / stylelint related changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants