Skip to content

feat(chore): use modern "let" instead of "var" in build scripts #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 12, 2022
Merged

feat(chore): use modern "let" instead of "var" in build scripts #2597

merged 7 commits into from
Dec 12, 2022

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Dec 11, 2022 •
edited
Loading

Modernize code using eslint advisory introduced in GH-2596. This PR focuses on fixing no-var rule.

For src/* files it cannot be fixed (now) because of limited support in IE11.

@request-info
Copy link

request-info bot commented Dec 11, 2022

Hey, it looks like you didn't provide much info about your issue/pr. We would appreciate it if you could provide us with more information so we can better understand your issue or pull request.

@mvorisek mvorisek mentioned this pull request Dec 11, 2022
Merged
@mvorisek mvorisek changed the title Fix no-var eslint rule for non src/* files Fix "no-var" eslint rule for non src/* files Dec 11, 2022
@mvorisek mvorisek changed the title Fix "no-var" eslint rule for non src/* files Use modern "let" (instead of "var") in non src/* files Dec 11, 2022
@mvorisek mvorisek mentioned this pull request Dec 11, 2022
Merged
@mvorisek mvorisek changed the title Use modern "let" (instead of "var") in non src/* files Use modern "let" (instead of "var") in Node.js scripts Dec 11, 2022
@mvorisek mvorisek changed the title Use modern "let" (instead of "var") in Node.js scripts Use modern "let" (instead of "var") in build scripts Dec 11, 2022
@mvorisek
Copy link
Contributor Author

Hi @lubber-de, if there is no feedback left let's merge this PR and then #2598 and #2599 (in this order, there should be no conflict).

lubber-de
lubber-de approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally understood your "configDocs" change (i actually learned/refreshed a bit of my javascript knowledge today). Thanks for making a single PR out of it, was worth it (for me 😆 )

LGTM

@lubber-de lubber-de changed the title Use modern "let" (instead of "var") in build scripts feat(chore): use modern "let" instead of "var" in build scripts Dec 12, 2022
@lubber-de lubber-de merged commit ae427cc into fomantic:develop Dec 12, 2022
@mvorisek mvorisek deleted the airbnb_part2 branch December 12, 2022 09:42
@lubber-de lubber-de added type/feat Any feature requests or improvements lang/javascript Anything involving JavaScript type/chore Anything which is a project chore and removed needs-more-info labels Dec 12, 2022
@lubber-de lubber-de added this to the 2.9.1 milestone Dec 12, 2022
@lubber-de
Copy link
Member

Hi @lubber-de, if there is no feedback left let's merge this PR and then #2598 and #2599 (in this order, there should be no conflict).

Both other PRs have merge conflicts now. Please resolve 🙂

@lubber-de lubber-de added the type/lint eslint / stylelint related changes only label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubber-de lubber-de lubber-de approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

@exoego exoego Awaiting requested review from exoego

@y0hami y0hami Awaiting requested review from y0hami

@ko2in ko2in Awaiting requested review from ko2in

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/javascript Anything involving JavaScript type/chore Anything which is a project chore type/feat Any feature requests or improvements type/lint eslint / stylelint related changes only
Projects
None yet
Milestone
2.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @lubber-de