Skip to content

feat(dropdown): change forceSelection default to false #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 9, 2021
Merged

feat(dropdown): change forceSelection default to false #1747

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b378a6
feat(dropdown): change forceSelection default
lubber-de Nov 3, 2020
544196e
Merge branch 'develop' into feat/dropdown/forceSelectionFalseDefault
lubber-de May 16, 2021
cc57190
Merge branch 'develop' into feat/dropdown/forceSelectionFalseDefault
lubber-de Jun 25, 2021
65a3d96
Merge branch 'develop' into feat/dropdown/forceSelectionFalseDefault
lubber-de Aug 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/definitions/modules/dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,9 @@ $.fn.dropdown = function(parameters) {
module.debug('Disabling dropdown');
$module.addClass(className.disabled);
}
if($input.is('[required]')) {
settings.forceSelection = true;
}
$input
.removeAttr('required')
.removeAttr('class')
Expand Down Expand Up @@ -3986,7 +3989,7 @@ $.fn.dropdown.settings = {
preserveHTML : true, // preserve html when selecting value
sortSelect : false, // sort selection on init

forceSelection : true, // force a choice on blur with search selection
forceSelection : false, // force a choice on blur with search selection

allowAdditions : false, // whether multiple select should allow user added values
ignoreCase : false, // whether to consider case sensitivity when creating labels
Expand Down