feat(dropdown): change forceSelection default to false #1747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/feat
exoego
approved these changes
Nov 4, 2020
lubber-de
added
the
state/awaiting-docs
lubber-de
added
state/on-hold
lubber-de
changed the title
lubber-de
removed
the
state/on-hold
|
Docs added by fomantic/Fomantic-UI-Docs#294 |
lubber-de
added
state/has-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes default value for
forceSelectiontofalse, because if you click into a dropdownfield and click outside again, the first dropdown value will be selected automatically which is probably not wanted in most cases so it shouldn't be the default.If a
selectHTML field to be converted into a FUI dropdownfield got arequiredattribute, theforceSelectionsetting will be set totrueagain automaticallyAs this is a breaking change it is supposed to be part of 2.9
Closes
#1742