Orbit for Windows ARM64 #27882
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| version: 2 | ||
|
|
||
| project_name: orbit | ||
|
|
||
| ################################################################################################# | ||
| # If this is updated make sure to update the "How to build from source" section in the README.md. | ||
| ################################################################################################# | ||
|
|
||
| builds: | ||
| - id: orbit | ||
| dir: ./orbit/cmd/orbit/ | ||
| binary: orbit | ||
| env: | ||
| - CGO_ENABLED=0 | ||
| goos: | ||
| - windows | ||
| goarch: | ||
| - arm64 | ||
| flags: | ||
| - -trimpath | ||
| ldflags: | ||
| - -X github.com/fleetdm/fleet/v4/orbit/pkg/build.Version={{.Version}} | ||
| - -X github.com/fleetdm/fleet/v4/orbit/pkg/build.Commit={{.Commit}} | ||
| - -X github.com/fleetdm/fleet/v4/orbit/pkg/build.Date={{.Date}} | ||
| hooks: | ||
| pre: "go run ./orbit/tools/build/build-windows.go -version {{.Version}} -input ./orbit/cmd/orbit -resource=true -arch arm64" | ||
|
|
||
| archives: | ||
| - id: orbit | ||
| builds: | ||
| - orbit | ||
| name_template: orbit_{{.Version}}_{{.Os}} | ||
| format_overrides: | ||
| - goos: windows | ||
| format: zip | ||
|
|
||
| checksum: | ||
| name_template: 'checksums.txt' | ||
|
|
||
| snapshot: | ||
| version_template: "{{ .Tag }}-untagged" | ||
|
|
||
| changelog: | ||
| disable: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,6 +54,20 @@ var ( | |
| }, | ||
| } | ||
|
|
||
| WindowsArm64Targets = Targets{ | ||
| constant.OrbitTUFTargetName: TargetInfo{ | ||
| Platform: "windows-arm64", | ||
| Channel: "stable", | ||
| TargetFile: "orbit.exe", | ||
| }, | ||
| // NOTE: Currently osquery doesn't fully support ARM64, continue to use the x86 version for now | ||
|
There was a problem hiding this comment. Am curious does the Windows arm64 provided in the Github releases not work? There was a problem hiding this comment. Hey Lucas! So I'm still a little uncertain about osquery's windows ARM support. They don't have build instructions on their website and I've tried my best to build it locally but failed. This isn't a total dealbreaker but it means that we cannot submit bug fixes upstream if we find an issue with it for the time being. I've also noticed that it doesn't return the There was a problem hiding this comment. I would suggest discussing it with the product team. Maybe we can release fleetd for Windows ARM64 as beta/alpha (to get gears moving). There was a problem hiding this comment. (Because the user/customer requesting this wanted to avoid emulation.) There was a problem hiding this comment. Since this release is going to be a "newly supported" platform, I could also just use it and we mark it as experimental There was a problem hiding this comment. @noahtalerman Do you have any input on this? There was a problem hiding this comment. @lucasmrod One problem I've noticed with the ARM version of osquery is that it doesn't report the processor information at all. I'm also not able to debug the issue because I can't compile it locally though. |
||
| constant.OsqueryTUFTargetName: TargetInfo{ | ||
| Platform: "windows", | ||
| Channel: "stable", | ||
| TargetFile: "osqueryd.exe", | ||
| }, | ||
| } | ||
|
|
||
| WindowsTargets = Targets{ | ||
| constant.OrbitTUFTargetName: TargetInfo{ | ||
| Platform: "windows", | ||
|
|
@@ -80,6 +94,12 @@ var ( | |
| TargetFile: constant.DesktopAppExecName + ".exe", | ||
| } | ||
|
|
||
| DesktopWindowsArm64Target = TargetInfo{ | ||
| Platform: "windows-arm64", | ||
| Channel: "stable", | ||
| TargetFile: constant.DesktopAppExecName + ".exe", | ||
| } | ||
|
|
||
| DesktopLinuxTarget = TargetInfo{ | ||
| Platform: "linux", | ||
| Channel: "stable", | ||
|
|
||
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| package update | ||
|
|
||
| import ( | ||
| "os" | ||
| "path/filepath" | ||
|
|
||
| "github.com/theupdateframework/go-tuf/client" | ||
| ) | ||
|
|
||
| var defaultOptions = Options{ | ||
| RootDirectory: `C:\Program Files\Orbit`, | ||
| ServerURL: DefaultURL, | ||
| RootKeys: defaultRootMetadata, | ||
| LocalStore: client.MemoryLocalStore(), | ||
| InsecureTransport: false, | ||
| Targets: WindowsArm64Targets, | ||
| } | ||
|
|
||
| func init() { | ||
| // Set root directory to value of ProgramFiles environment variable if not set | ||
| if dir := os.Getenv("ProgramFiles"); dir != "" { | ||
| DefaultOptions.RootDirectory = filepath.Join(dir, "Orbit") | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noahtalerman @dantecatalfamo Should we add a note somewhere in the output that
fleetctl package --type=msi --arch=arm64 [...]is experimental?