Begin work on windows arm64 #27882
Draft
Begin work on windows arm64 #27882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
dantecatalfamo
changed the title
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
lucasmrod
reviewed
Apr 4, 2025
| return "", fmt.Errorf("build package: %w", err) | ||
| } | ||
|
|
||
| if err := wix.Light(tmpDir, opt.NativeTooling, absWixDir); err != nil { | ||
| return "", fmt.Errorf("build package: %w", err) | ||
| } | ||
|
|
||
| filename := "fleet-osquery.msi" | ||
| filename := fmt.Sprintf("fleet-osquery_%s_%s.msi", opt.Version, opt.Architecture) |
There was a problem hiding this comment.
We should keep the amd64 one the same name (without prefix).
To not break customer automations that are assuming the name of the output.
(And not add version for now until/if we decide to do it for pkg too.)
There was a problem hiding this comment.
lucasmrod
reviewed
Apr 4, 2025
| Channel: "stable", | ||
| TargetFile: "orbit.exe", | ||
| }, | ||
| // NOTE: Currently osquery doesn't fully support ARM64, continue to use the x86 version for now |
There was a problem hiding this comment.
Am curious does the Windows arm64 provided in the Github releases not work?
lucasmrod
reviewed
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)cmd/osquery-perffor new osquery data ingestion features.COLLATE utf8mb4_unicode_ci).runtime.GOOS).