UI – update 4 Software > details pages with desired empty state for 404 responses #16944
Conversation
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 15919-vulnerabilities-page #16944 +/- ##
=============================================================
Coverage ? 51.88%
=============================================================
Files ? 331
Lines ? 7600
Branches ? 2472
=============================================================
Hits ? 3943
Misses ? 3635
Partials ? 22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
jacobshandling
changed the title
|
@jacobshandling I recently did some work on showing error pages for incorrect permissions for viewing software here https://github.com/fleetdm/fleet/pull/16561/files#diff-21f40eda68a8ae68da1327e18c2fbe1337e06f7e6be0b5d0325954d5794e6bc9. Im not sure if this will effect your changes but you might want to pull in main and see if everything works as expected still. This work was part of this issue to add auth checks to viewing software. |
jacobshandling
force-pushed
the
updates-to-frontend-empty-states
branch
from
b713bf8 to
ca13d15
Compare
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
| @@ -103,7 +102,13 @@ const SoftwareOSDetailsPage = ({ | |||
| { | |||
| enabled: !!osVersionIdFromURL, | |||
| select: (data) => data.os_version, | |||
| onError: (error) => handlePageError(error), | |||
| onError: (error) => { | |||
| // 403s returned for both non-existent and non-accessable entities | |||
There was a problem hiding this comment.
I knew something didn't look right there!
There was a problem hiding this comment.
100 ty for jumping on error states
Addresses #16948