expect 403s on sw details pages instead of 404s

Author: Jacob Shandling

frontend/pages/SoftwarePage/SoftwareOSDetailsPage/SoftwareOSDetailsPage.tsx

@@ -103,9 +103,9 @@ const SoftwareOSDetailsPage = ({
       enabled: !!osVersionIdFromURL,
       select: (data) => data.os_version,
       onError: (error) => {
-        // 404s returned for both non-existent and non-accessable entities
+        // 403s returned for both non-existent and non-accessable entities
         // which we intentionally handle with the same empty state for security
-        if (isAxiosError(error) && error.response?.status !== 404) {
+        if (isAxiosError(error) && error.response?.status !== 403) {
           handlePageError(error);
         }
       },
@@ -161,7 +161,7 @@ const SoftwareOSDetailsPage = ({
             onTeamChange={onTeamChange}
           />
         )}
-        {/* at this point, error can only be 404 per above handling */}
+        {/* at this point, error can only be 403 per above handling */}
         {isOsVersionError ? (
           <DetailsNoHosts
             header="OS not detected"

frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/SoftwareTitleDetailsPage.tsx

@@ -75,9 +75,9 @@ const SoftwareTitleDetailsPage = ({
     {
       select: (data) => data.software_title,
       onError: (error) => {
-        // 404s returned for both non-existent and non-accessable entities
+        // 403s returned for both non-existent and non-accessable entities
         // which we intentionally handle with the same empty state for security
-        if (isAxiosError(error) && error.response?.status !== 404) {
+        if (isAxiosError(error) && error.response?.status !== 403) {
           handlePageError(error);
         }
       },
@@ -109,7 +109,7 @@ const SoftwareTitleDetailsPage = ({
             onTeamChange={onTeamChange}
           />
         )}
-        {/* at this point, error can only be 404 per above handling */}
+        {/* at this point, error can only be 403 per above handling */}
         {isSoftwareTitleError ? (
           <DetailsNoHosts
             header="Software not detected"

frontend/pages/SoftwarePage/SoftwareVersionDetailsPage/SoftwareVersionDetailsPage.tsx

@@ -78,9 +78,9 @@ const SoftwareVersionDetailsPage = ({
     {
       select: (data) => data.software,
       onError: (error) => {
-        // 404s returned for both non-existent and non-accessable entities
+        // 403s returned for both non-existent and non-accessable entities
         // which we intentionally handle with the same empty state for security
-        if (isAxiosError(error) && error.response?.status !== 404) {
+        if (isAxiosError(error) && error.response?.status !== 403) {
           handlePageError(error);
         }
       },
@@ -128,7 +128,7 @@ const SoftwareVersionDetailsPage = ({
             onTeamChange={onTeamChange}
           />
         )}
-        {/* at this point, error can only be 404 per above handling */}
+        {/* at this point, error can only be 403 per above handling */}
         {isSoftwareVersionError ? (
           <DetailsNoHosts
             header="Software not detected"

frontend/pages/SoftwarePage/SoftwareVulnerabilityDetailsPage/SoftwareVulnerabilityDetailsPage.tsx

@@ -80,9 +80,9 @@ const SoftwareVulnerabilityDetailsPage = ({
     {
       select: (data) => data.vulnerability,
       onError: (error) => {
-        // 404s returned for both non-existent and non-accessable entities
+        // 403s returned for both non-existent and non-accessable entities
         // which we intentionally handle with the same empty state for security
-        if (isAxiosError(error) && error.response?.status !== 404) {
+        if (isAxiosError(error) && error.response?.status !== 403) {
           handlePageError(error);
         }
       },
@@ -137,7 +137,7 @@ const SoftwareVulnerabilityDetailsPage = ({
             onTeamChange={onTeamChange}
           />
         )}
-        {/* at this point, error can only be 404 per above handling */}
+        {/* at this point, error can only be 403 per above handling */}
         {isVulnError ? (
           <DetailsNoHosts
             header="Vulnerability not detected"